Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 336926 - New ebuild: phpmyadmin-3.3.7
Summary: New ebuild: phpmyadmin-3.3.7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All OS X
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on: 336922 336924 338041
Blocks:
  Show dependency tree
 
Reported: 2010-09-12 15:44 UTC by nietonfir
Modified: 2010-09-21 19:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
phpmyadmin-3.3.7 ebuild (phpmyadmin-3.3.7.ebuild,1.36 KB, text/plain)
2010-09-12 15:46 UTC, nietonfir
Details
proposed patch for the webapp.eclass (webapp.eclass.patch,1.24 KB, patch)
2010-09-12 15:51 UTC, nietonfir
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nietonfir 2010-09-12 15:44:40 UTC
I usually forget to update pma on a regular basis, so I finally decided to port it. (It's been a year on my agenda :P)
The ebuild is basically ecopied. I had to strip ${EPREFIX} from ${MY_HTDOCSDIR} (else it would not be installed) because it gets appended in the webapp.eclass and as a result the default output messages are prefixed-stripped. On the other hand ${FILESDIR} needed to keep the prefix*.

*Imho the eclass is inconsistent in its inner calls to webapp_checkfileexists (sometimes with ${ED}, sometimes not) but I don't really want to mess with it because I don't know if it'll break anything. Nevertheless I will include a diff so you/somebody can test it.
Comment 1 nietonfir 2010-09-12 15:46:30 UTC
Created attachment 246980 [details]
phpmyadmin-3.3.7 ebuild

As mentioned in the first post:
* ecopied
* eprefixed-stripped ${MY_HTDOCSDIR}
* untouched ${FILESDIR}
Comment 2 nietonfir 2010-09-12 15:51:36 UTC
Created attachment 246981 [details, diff]
proposed patch for the webapp.eclass

As mentioned above the webapp.eclass is not consistent in its calls to webapp_checkfileexists, eg webapp_configfile calls it with ${ED}, webapp_postinst_txt without. As a result it is not clear when ${EPREFIX} has to be stripped from a variable.

I don't think that breakage in the main tree could occur with that patch, but I'm pretty sure some prefixified ebuilds using webapp (and some of the currently not ${ED} postfixed calls) will break.
Comment 3 Florian CROUZAT (SuperFlo) 2010-09-12 21:18:58 UTC
(In reply to comment #0)
> I usually forget to update pma on a regular basis, so I finally decided to port
> it. (It's been a year on my agenda :P)

Yeah thank you, I also moved on because of this bug. Almost two years I hadn't updated pma. I'll add it's an import request for x64-macos since you didn't mentioned it directly (only in the ebuild and your other related bugs: 336922 336924)
Comment 4 Fabian Groffen gentoo-dev 2010-09-21 19:43:56 UTC
the calls without ED, are actually intended (see gx86), they do a local lookup
Comment 5 Fabian Groffen gentoo-dev 2010-09-21 19:57:32 UTC
ok, added to prefix, we need to sort out the eclasses first before moving it to gx86