Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 336878 - x11-misc/x11vnc-0.9.12 fails to emerge with poor programming practices
Summary: x11-misc/x11vnc-0.9.12 fails to emerge with poor programming practices
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Sven Wegener
URL:
Whiteboard:
Keywords:
: 336915 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-12 00:01 UTC by Alexandre Ferreira
Modified: 2010-09-25 20:18 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to correct error. (x11vnc-0.9.12-warnings.patch,2.32 KB, patch)
2010-09-12 00:03 UTC, Alexandre Ferreira
Details | Diff
new ebuild that uses the patch (x11vnc-0.9.12.ebuild,1.95 KB, text/plain)
2010-09-12 00:04 UTC, Alexandre Ferreira
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Ferreira 2010-09-12 00:01:08 UTC
x11vnc-0.9.12 fails to emerge with error in:
/usr/include/bits/string3.h:52: warning: call to __builtin___memcpy_chk will always overflow destination buffer


Reproducible: Always

Steps to Reproduce:
1.emerge x11vnc-0.9.12
2.
3.

Actual Results:  
 
 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * 
 * /usr/include/bits/string3.h:52: warning: call to __builtin___memcpy_chk will always overflow destination buffer
 * 
 *  Please file a bug about this at http://bugs.gentoo.org/
 *  with the maintaining herd of the package.
 * 
 * 
 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * 
 * remote.c:5828: warning: the address of ‘vnc_desktop_name’ will always evaluate as ‘true’
 * remote.c:6030: warning: the address of ‘lastmod’ will always evaluate as ‘true’
 * sslhelper.c:4007: warning: the address of ‘rcookie’ will always evaluate as ‘true’
 * userinput.c:1308: warning: the address of ‘xrecord_name_info’ will always evaluate as ‘true’
 * 
 *  Please file a bug about this at http://bugs.gentoo.org/
 *  with the maintaining herd of the package.
 * 
 * ERROR: x11-misc/x11vnc-0.9.12 failed:
 *   install aborted due to poor programming practices shown above
 * 
 * Call stack:
 *   misc-functions.sh, line 975:  Called install_qa_check
 *   misc-functions.sh, line 660:  Called die
 * The specific snippet of code:
 *                              die "install aborted due to" \
 * 
 * If you need support, post the output of 'emerge --info =x11-misc/x11vnc-0.9.12',
 * the complete build log and the output of 'emerge -pqv =x11-misc/x11vnc-0.9.12'.
 * The complete build log is located at '/var/tmp/portage/x11-misc/x11vnc-0.9.12/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/x11-misc/x11vnc-0.9.12/temp/environment'.
 * S: '/var/tmp/portage/x11-misc/x11vnc-0.9.12/work/x11vnc-0.9.12'


Expected Results:  
emerge successful

Portage 2.2_rc79 (default/linux/amd64/10.0/desktop, gcc-4.4.4, glibc-2.12.1-r1, 2.6.36-rc3 x86_64)
=================================================================
System uname: Linux-2.6.36-rc3-x86_64-Intel-R-_Core-TM-2_Duo_CPU_T9550_@_2.66GHz-with-gentoo-2.0.1
Timestamp of tree: Sat, 11 Sep 2010 21:00:22 +0000
distcc 3.1 x86_64-pc-linux-gnu [disabled]
app-shells/bash:     4.1_p7
dev-java/java-config: 2.1.11
dev-lang/python:     2.6.5-r3, 3.1.2-r4
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.3
sys-apps/sandbox:    2.3-r1
sys-devel/autoconf:  2.13, 2.67
sys-devel/automake:  1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.4.4-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.81-r2
virtual/os-headers:  2.6.35 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/X11/xkb /usr/share/config /var/bind /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests distlocks fixlafiles fixpackages news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_US pt pt_BR"
MAKEOPTS="-j 3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/layman/kde /usr/local/portage/layman/x11 /usr/portages-other/my_portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="3dnow X Xaw3d a52 aac aalib accessibility acl acpi alsa amd64 apache2 asf ati atk audiofile avi berkdb blas bluetooth branding bzip2 bzlib cairo cdparanoia cdr cli consolekit cracklib cross crypt cscope ctype cups curl curlwrappers cxx dba dbus dhcpcd divx divx4linux doc dri dts dvd dvdr dvdread emboss encode ethereal exif fam ffmpeg firefox flac fontconfig foomaticdb fortran gd gdbm ggi gif glitz glut gpm graphviz gstreamer gtk gtk2 gtkhtml guile h323 hal iconv icq imagemagick imap imlib innodb ipod ipv6 jabber jadetex java java5 joystick jpeg jpeg2k kde lapack laptop latex lcms ldap lesstif libcaca libg++ libkms libnotify lirc lm_sensors logrotate lua lzo mad matroska mcal mikmod mime mjpeg mmap mmx mng modules motif mp3 mp4 mpeg mplayer msn mudflap multilib musicbrainz mysql ncurses networking networkmanager nls no-seamonkey nptl nptlonly nsplugin ofx ogg oggvorbis openal opengl openmp pam pango pcre pdf pdflib perl php pic plotutils png policykit postgres ppds pppd python qt qt3support qt4 qthelp quicktime readline reflection rtc ruby samba scanner sdl secure-delete semantic-desktop session shared sip slp sndfile soap sockets speex spell sql srt sse sse2 ssl startup-notification subversion svg sysfs tcltk tcpd theora threads tiff tk truetype udev unicode upnp usb v4l v4l2 vcd vorbis wav webkit wlm wmp wxwindows x264 xcb xcomposite xine xinerama xml xml2 xorg xpm xscreensaver xsl xulrunner xv xvid xvmc zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse synaptics evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en en_US pt pt_BR" LIRC_DEVICES="ite8709" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="radeon r600" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Alexandre Ferreira 2010-09-12 00:03:14 UTC
Created attachment 246919 [details, diff]
patch to correct error.

Correct the error in the file x11vnc/libvncserver/tightvnc-filetransfer/filetransfermsg.c that is responsible for the problem. It also corrects the other warnings.
Comment 2 Alexandre Ferreira 2010-09-12 00:04:00 UTC
Created attachment 246920 [details]
new ebuild that uses the patch

Ebuild that uses the patch and emerges correctly
Comment 3 Alex Alexander (RETIRED) gentoo-dev 2010-09-14 06:31:27 UTC
*** Bug 336915 has been marked as a duplicate of this bug. ***
Comment 4 Sven Wegener gentoo-dev 2010-09-25 20:18:40 UTC
Thanks, commited.