Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 336873 - zlib-1.2.5.r2 QA notice
Summary: zlib-1.2.5.r2 QA notice
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-11 23:08 UTC by David J Cozatt
Modified: 2010-09-13 16:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
zlib build log (have several this is ther first from yesterday should be the right one) (sys-libs:zlib-1.2.5-r2:20100911-224334.log,148 bytes, text/plain)
2010-09-12 10:22 UTC, David J Cozatt
Details
emerge --info (emerge-info,3.60 KB, text/plain)
2010-09-12 10:26 UTC, David J Cozatt
Details
zlib-build.log (build.log,7.53 KB, text/plain)
2010-09-12 11:03 UTC, David J Cozatt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David J Cozatt 2010-09-11 23:08:53 UTC
Applying zlib-1.2.5-ldflags.patch ...                                         │
│Applying zlib-1.2.5-lfs-decls.patch ...                                       │
│Applying zlib-1.2.5-fbsd_chosts.patch ...                                     │
│                                                                              │
│QA: other                                                                     │
│^[[31;01mQA Notice: Files built without respecting LDFLAGS have been          │
│detected^[[0m        
  Please include the following list of files in your report:                   │
│/lib64/libz.so.1.2.5    

Reproducible: Always




emerge --info is available
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-12 09:29:07 UTC
(In reply to comment #0)
> emerge --info is available

Then please attach it (best 'emerge --info zlib') along with the complete build log.

This bug looks quite suspicious, especially that I see it applying ldflags patch, and I can't reproduce the issue myself.
Comment 2 David J Cozatt 2010-09-12 10:17:19 UTC
oddly I cannot seem to reproduce it myself. 

Here is how it came up .

LDFLAGS="Wl, --as-needed"
then wrongly set on the end '--hash-style=gnu'  to the end like this 
LDFLAGS="-Wl, --as-needed ==hash-style=gnu" then did emerge -ev world

zlib was the first package to rebuild and I got the message a couple other packages managed to 
build before expat decided the compiler couldn't spit out code and failed. Anyway I have since changed the LDFLAGS but changing back and trying to reproduce would not give the same message ...still I will post the requested info asap

Comment 3 David J Cozatt 2010-09-12 10:18:38 UTC
typo in comment #2 those are "--" not '==' in the LDFLAGS
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-12 10:20:06 UTC
Zac, are we interested in making the LDFLAGS check smarter?
Comment 5 David J Cozatt 2010-09-12 10:22:11 UTC
Created attachment 246954 [details]
zlib build log (have several this is ther first from yesterday should be the right one)
Comment 6 David J Cozatt 2010-09-12 10:26:55 UTC
Created attachment 246955 [details]
emerge --info

Now these LDFLAGS do not show those that were in affect when this showed up

LDFLAGS="Wl, --as-needed --hash-style=gnu"

was what got the QA message
Comment 7 David J Cozatt 2010-09-12 10:51:02 UTC
hmm I have 'autoclean' set and this is the wrong entry message (from elog only) 
/var/tmp/portage/sys-libs/  shows only last failed build and it installed though it spit out the QA message

if interested I while try to reproduce and unset autoclean to get a real buildlog

Comment 8 David J Cozatt 2010-09-12 11:03:11 UTC
Created attachment 246957 [details]
zlib-build.log

attached build log
Comment 9 David J Cozatt 2010-09-12 11:04:08 UTC
vid@random ~ $ emerge --info zlib
Portage 2.1.9.3 (default/linux/amd64/10.0, gcc-4.4.4, glibc-2.12.1-r1, 2.6.35-gentoo-r5 x86_64)
=================================================================
                        System Settings
=================================================================
System uname: Linux-2.6.35-gentoo-r5-x86_64-AMD_Athlon-tm-_64_Processor_3200+-with-gentoo-2.0.1
Timestamp of tree: Sat, 11 Sep 2010 18:30:01 +0000
app-shells/bash:     4.1_p7
dev-java/java-config: 2.1.11
dev-lang/python:     2.6.5-r3, 3.1.2-r4
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.3
sys-apps/sandbox:    2.3-r1
sys-devel/autoconf:  2.13, 2.67
sys-devel/automake:  1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.4.4-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.81-r2
virtual/os-headers:  2.6.35 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/portage/ /usr/share/X11/xkb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests buildpkg distlocks fixlafiles fixpackages multilib-strict news noclean parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://ftp.gtlib.gatech.edu/pub/gentoo/ ftp://gentoo.chem.wisc.edu/gentoo/ http://mirrors.163.com/gentoo/ ftp://mirror.bih.net.ba/gentoo/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,--as-needed --hash-style=gnu"
LINGUAS="en_US"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="   "
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="acl alsa amd64 berkdb bzip2 cdr cli cracklib crypt cups cxx dri fortran gdbm gpm gtk iconv ipv6 midi mmx modules mudflap multilib ncurses nls nptl nptlonly openmp pam pcre perl pppd python readline reflection session sse sse2 ssl sysfs tcpd threads unicode xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="evdev keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en_US" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="nv nvidia vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

sys-libs/zlib-1.2.5-r2 was built with the following:
USE="(multilib)" 

Comment 10 David J Cozatt 2010-09-12 11:36:56 UTC
I will add here that the build fails completely when I change to the proper appendage of the flag
as reported here http://www.gentoo.org/proj/en/base/amd64/at/index.xml

And change to 
LDFLAGS="-Wl, --as-needed -Wl, --hash-style=gnu" 

do I need to build the toolchain with the flags first to be able to use them?
Or am I reading the information wrong? I have been using the --as-needed for quite some time
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-12 15:55:05 UTC
(In reply to comment #10)
> And change to 
> LDFLAGS="-Wl, --as-needed -Wl, --hash-style=gnu" 

LDFLAGS="-Wl,--as-needed -Wl,--hash-style=gnu"

i.e. no space between '-Wl,' and the flag.
Comment 12 Zac Medico gentoo-dev 2010-09-12 22:46:56 UTC
(In reply to comment #4)
> Zac, are we interested in making the LDFLAGS check smarter?

If only invalid configurations trigger this problem then I think the existing code is probably fine. It might be hard to handle all possible invalid configurations.
Comment 13 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-13 07:02:43 UTC
(In reply to comment #12)
> If only invalid configurations trigger this problem then I think the existing
> code is probably fine. It might be hard to handle all possible invalid
> configurations.

Hm, how about prepending the --hash... check with a comma? That should be a little safer, and work with -Wl,--someopt,--someotheropt,--hash-style=gnu.
Comment 14 Zac Medico gentoo-dev 2010-09-13 07:38:27 UTC
(In reply to comment #13)
> Hm, how about prepending the --hash... check with a comma? That should be a
> little safer, and work with -Wl,--someopt,--someotheropt,--hash-style=gnu.

Ok, that's in git now:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=f58a8ee3b984738cf9cfdcf7e0e221635f719e31
Comment 15 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-13 16:35:13 UTC
Ok, I think we did what we could here. Closing as INVALID as the bug was due to incorrect user-set LDFLAGS.