Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 336803 - Please stabilise app-editors/jove-4.16.0.73
Summary: Please stabilise app-editors/jove-4.16.0.73
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2010-09-11 10:33 UTC by Ulrich Müller
Modified: 2010-10-14 16:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2010-09-11 10:33:59 UTC
Test plan: <http://overlays.gentoo.org/proj/emacs/wiki/test%20plans>

@ppc: New stabilisation for you, so as usual, you may remove yourself from CC.

Thanks in advance.
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2010-09-12 15:43:53 UTC
The package doesn't respect the ldflags 

* QA Notice: Files built without respecting LDFLAGS have been detected                          *  Please include the following list of files in your report:                                                                         

 * /usr/bin/teachjove                                                                                                                                                               
 * /usr/bin/jove                                                                                                                                                    
 * /usr/lib/jove/recover      
Comment 2 Ulrich Müller gentoo-dev 2010-09-12 16:03:44 UTC
(In reply to comment #1)
> The package doesn't respect the ldflags
>
> * QA Notice: Files built without respecting LDFLAGS have been detected
>  *  Please include the following list of files in your report:
>
>  * /usr/bin/teachjove
>  * /usr/bin/jove
>  * /usr/lib/jove/recover

Sorry, but I cannot follow. Is that related to version 4.16.0.73?
From my build.log, it appears that LDFLAGS are honoured:

gcc -O -Wl,-O1 -Wl,--as-needed -march=core2 -ggdb -O2 -pipe -o teachjove teachjove.o
gcc -O -Wl,-O1 -Wl,--as-needed -march=core2 -ggdb -O2 -pipe -o recover recover.o
gcc -O -Wl,-O1 -Wl,--as-needed -march=core2 -ggdb -O2 -pipe -o jjove commands.o keys.o argcount.o ask.o buf.o jctype.o delete.o disp.o insert.o io.o jove.o marks.o misc.o re.o screen.o termcap.o unix.o util.o vars.o list.o keymaps.o mouse.o abbrev.o rec.o paragraph.o fmt.o c.o wind.o fp.o move.o extend.o macros.o iproc.o reapp.o proc.o scandir.o term.o case.o -lncurses
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2010-09-12 16:21:08 UTC
Yes

Apparently some of the object files that get linked all together to build the final binaries have been built without your LDFLAGS. I assume you are looking at the wrong place in the build.log

Look at these lines:

x86_64-pc-linux-gnu-gcc -Wall -ggdb -march=amdfam10 -O2 -pipe -DSYSVR4 -_XOPEN_SOURCE=500   -c -o case.o case.c 
x86_64-pc-linux-gnu-gcc -Wall -ggdb -march=amdfam10 -O2 -pipe -DSYSVR4 -D_XOPEN_SOURCE=500   -c -o recover.o recover.c
x86_64-pc-linux-gnu-gcc -Wall -ggdb -march=amdfam10 -O2 -pipe -DSYSVR4 -D_XOPEN_SOURCE=500   -c -o teachjove.o teachjove.c
x86_64-pc-linux-gnu-gcc -Wall -ggdb -march=amdfam10 -O2 -pipe -DSYSVR4 -D_XOPEN_SOURCE=500   -c -o portsrv.o portsrv.c 

See? These object files are built without my/your LDFLAGS so when they link together to produce the final binary you get warnings about the missing LDFLAGS
Comment 4 Tomáš Chvátal (RETIRED) gentoo-dev 2010-09-12 16:45:32 UTC
Markos, however i try to reproduce your non-respected LDFLAGS i cant.
Please try to cleanup all temp files, update to latest portage and try again :)

Tested on 2 stable boxes (amd64 and x86) + my dev amd64 system, good to go i would say.
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2010-09-12 19:56:22 UTC
That was an error on my end ( what a surprise )

amd64 done
Comment 6 Christian Faulhammer (RETIRED) gentoo-dev 2010-09-14 17:07:36 UTC
x86 stable
Comment 7 Brent Baude (RETIRED) gentoo-dev 2010-10-14 16:53:19 UTC
ppc stable, closing