You see here a slice out of /etc/inittab # /etc/inittab: This file describes how the INIT process should set up # the system in a certain run-level. # #::: $Header: /home/cvsroot/gentoo-src/rc-scripts/etc/inittab,v 1.6 2003/01/06 21:32:43 azarah Exp $ please note that I have added three (3) colons to the beginning of the header line. When Webmin's SYS V Init module parses this file it is looking for any line that had 2 colons, ':', even if they are are after a hash, '#', that would normally be a comment. This is done so that inactive (commented out) items in the inittab will be shown (correctly) in the Webmin panel for Sys V Init. Note that the $Header line, by coincidence, matches this regexp. Small Bad. My change fools the regexp into thinking that there is nothing to report for the "inactive" line that has the $Header. Reproducible: Always Steps to Reproduce: 1. Run Webmin on a machine with Sys V Init installed 2. go to the System/ Sys V module panel and you will see the $Header as a line item 3. Actual Results: put a bogus line into the webmin panel for the $Header line in the config file Expected Results: ignored the line Portage 2.0.49-r15 (default-x86-1.4, gcc-3.2.3, glibc-2.3.2-r1, 2.4.20-gentoo-r7) ================================================================= System uname: 2.4.20-gentoo-r7 i686 Pentium II (Klamath) Gentoo Base System version 1.4.3.10 distcc 2.9 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled] ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CFLAGS="-march=pentium2 -O2 -fomit-frame-pointer -pipe" CHOST="i686-pc-linux-gnu" COMPILER="gcc3" CONFIG_PROTECT="/etc /var/qmail/control /usr/share/config /usr/kde/2/share/config /usr/kde/3/share/config /usr/X11R6/lib/X11/xkb /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/" CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d" CXXFLAGS="-march=pentium2 -O2 -fomit-frame-pointer -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="sandbox ccache autoaddcvs" GENTOO_MIRRORS="ftp://ftp.gentoo.skynet.be/pub/gentoo/ ftp://ftp.belnet.be/mirror/rsync.gentoo.org/gentoo/ ftp://ftp.easynet.nl/mirror/gentoo/ http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.be.gentoo.org/gentoo-portage" USE="x86 avi crypt encode foomaticdb gif jpeg libg++ mad mikmod mpeg ncurses pdflib png sdl spell svga truetype xml2 xmms xv zlib alsa gdbm berkdb slang readline tetex tcltk mysql X gpm tcpd pam libwww ssl perl python esd imlib oggvorbis gnome gtk motif opengl mozilla cdr aalib aavm acl acpi acpi4linux amd apache2 autofs bonobo bsh cscope curl dga dnd doc fastcgi gnomedb gtkhtml jack java javascript jikes mmx moznocompose moznoirc moznomail mozp3p offensive openssh pic rage128 samba stroke tiff usb vim-with-x wmf X509 -oss -apm -arts -cups -kde -nls -qt -quicktime"
Martin, will you pick this one up or should it be reassigned to Jeremy (the current maintainer of webmin)? Jeff, if this is not applicable anymore, please let us know.
No response, and it's not really a problem, IMO
well, the problem happens when someone, not knowing what a CVS header is, enables this SYSV feature. I did not try it but i imagine that will mess up the inittab a bit eh? sorry for not responsding earlier .. i did see the notice asking me to. I re-tested in the latest Webmin and found the problem still existed. if you want to leave this as WONTFIX i dont mind .. i will just always patch my version to avoid the problem :-)
yeah, but if I read this right, it REQUIRES somebody to INTENTIONALLY add extra :s to the header to cause the problem, so honestly, I don't really care. If someone does that, too bad... If you want to make a patch for it to properly detect that problem, be my guest, and I'll add it and send it upstream, but as it is, it's staying WONTFIX...
