Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 33563 - in /usr/share/emacs/site-lisp/site-start.el the load path is not correctly initialized for cscope
Summary: in /usr/share/emacs/site-lisp/site-start.el the load path is not correctly in...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-15 10:39 UTC by Anupam Kapoor
Modified: 2003-11-15 12:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anupam Kapoor 2003-11-15 10:39:36 UTC
/usr/share/emacs/site-lisp/site-start.el the load path for xcscope is
initialized as:
            (add-to-list 'load-path "@SITELISP@")


Reproducible: Always
Steps to Reproduce:
1. emerge cscope-15.4.ebuild
2.
3.

Actual Results:  
/usr/share/emacs/site-lisp/site-start.el was regenerated with (add-to-list
'load-path "@SITELISP@") for cscope.

Expected Results:  
/usr/share/emacs/site-lisp/site-start.el should contain
(add-to-list 'load-path "/usr/share/emacs/site-lisp/cscope")


i have the fix for the problem. in the cscope-15.4.ebuild, we should be using
'elisp-site-file-install' instead of using 'doins' to install the elisp files.
also, in the ebuild, we should be using 'elisp-install' for installing *.el[c]
files. 

all fixes are to be done in the src_install() function of the ebuild.

also, another question (not related to this problem), in site-start.el, there
seems to be an inconsistency in the way the site files are added to the
load-path. for some cases, we have:

(setq load-path 
      (cons "/usr/share/emacs/site-lisp/dircolors" load-path)) 

and for other cases we have

(add-to-list 'load-path "/usr/share/emacs/site-lisp/htmlize")

shouldn't we be doing either of the two ?
Comment 1 Jeremy Maitin-Shepard 2003-11-15 12:11:06 UTC
As listed in the following reply (which might not yet have been circulated by the gentoo mailing list daemon, or perhaps there is some other problem), I made the necessary changes in CVS after receiving your post to gentoo-dev:

From: Jeremy Maitin-Shepard <jbms@gentoo.org>
Subject: Re: [gentoo-dev] cscope ebuilds
To: gentoo-dev@gentoo.org
Date: Sat Nov 15 13:34:47 2003 -0500

Anupam Kapoor <anupamk@speakeasy.net> writes:
> ok. got the fix. the problem was that for installing
> 50xcscope-gentoo.el, we were using a doins instead of using the normal
> 'elisp-site-file-install'. also we should have used elisp-install for
> installing the *.el[c] files. the changes fix the problem.

> two questions:
>     1. how do i send the changes back ?

No need.  I made these changes (and bumped revision) in CVS.  The
changes should be visible via rsync in approximately a half-hour.

>     2. in site-start.el, there seems to be an inconsistency in the way
>     the site files are added to the load-path. for some cases, we have 

> (setq load-path 
>       (cons "/usr/share/emacs/site-lisp/dircolors" load-path)) 

> and for other cases we have

> (add-to-list 'load-path "/usr/share/emacs/site-lisp/htmlize")

> shouldn't we be doing either of the two ?

Since these two methods are functionally equivalent, this is not very
critical.  Furthermore, I believe we will be revamping the site file
management system sometime soon.

-- 
Jeremy Maitin-Shepard