Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 335465 - samba: Remove unneeded patches
Summary: samba: Remove unneeded patches
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 21:58 UTC by Ewoud Kohl van Wijngaarden
Modified: 2010-09-26 17:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ewoud Kohl van Wijngaarden 2010-08-31 21:58:15 UTC
Currently, there are a lot of patches in the samba files directory and some aren't used anymore.

.../net-fs/samba/files $ for i in *.patch ; do grep -q $i ../*.ebuild || echo $i ; done | xargs du -ch
8.0K	3.0.28a-CVE-2008-1105.patch
4.0K	3.0.28-autoconf-2.62-fix.patch
4.0K	3.0.28-inotify_include.patch
4.0K	3.0.28-libcap_detection.patch
4.0K	3.5.2-backport-fix-ipv6-cifs-mount.patch
4.0K	3.5.2-backport-fix-smbclient-segfault.patch
28K	total

Reproducible: Always

Steps to Reproduce:
Comment 1 Ewoud Kohl van Wijngaarden 2010-08-31 21:58:50 UTC
Sorry for the spam, but the summary was a bit too generic.
Comment 2 Víctor Ostorga (RETIRED) gentoo-dev 2010-09-20 01:04:59 UTC
This was fixed 

  14 Sep 2010; Patrick Lauer <patrick@gentoo.org>
  -files/3.0.26a-invalid-free-fix.patch, -samba-3.0.37.ebuild,
  -samba-3.2.15.ebuild, -samba-3.2.15-r1.ebuild, -samba-3.5.3.ebuild,
  -samba-3.5.4.ebuild, -files/3.0.28a-CVE-2008-1105.patch,
  -files/3.0.28-inotify_include.patch,
  -files/3.0.28-autoconf-2.62-fix.patch, -files/3.0.37-CVE-2010-2063.patch,
  -files/3.2.15-CVE-2010-2063.patch, -files/3.0.26a-lazyldflags.patch,
  -files/3.0.28-fix_broken_readdir_detection.patch,
  -files/3.0.28-libcap_detection.patch,
  -files/3.0.28a-wrong_python_ldflags.patch,
  -files/3.0.37-allow-non-ASCII-netbios-names.patch,
  -files/3.2.15-core-dump-overlapping-byte-lock-test.patch,
  -files/3.2.15-smbclient-file-corruption-NT4.patch,
  -samba-3.0.37-r1.ebuild:
  Remove old

Thanks for the bug report
Comment 3 Ewoud Kohl van Wijngaarden 2010-09-20 07:44:59 UTC
Since samba 3.0 and 3.2 were removed, the config and config-3.2 directories are now useless. Same goes for README.gentoo, samba-{conf,init,xinetd}. Also, the 3.5.2-backport-fix-* patches are still in the files directory.

.../net-fs/samba/files $ for i in * ; do grep -q "$i" ../*.ebuild || echo $i ; done | xargs du -csh
4.0K	3.5.2-backport-fix-ipv6-cifs-mount.patch
4.0K	3.5.2-backport-fix-smbclient-segfault.patch
64K	config-3.2
4.0K	README.gentoo
4.0K	samba-conf
4.0K	samba-init
4.0K	samba-xinetd
88K	totalNotice that config isn't shown since src_configure contains config, but it was only used in the 3.0 ebuilds.
Comment 4 Víctor Ostorga (RETIRED) gentoo-dev 2010-09-26 17:25:31 UTC
Fixed.
Thanks for the heads up