Bug 335297 – net-misc/miredo: remove bashism from init.d script

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Kai Krakow 2010-08-30 17:26:19 UTC]

To conform with POSIX and use non-bash shells as default-sh with baselayout-2, the following bashism in the init.d script needs to be fixed ([[...]] syntax replaced by test, line 13+14):

test "${MIREDO_MODPROBE_IPV6}" = "yes" && modprobe ipv6                                                                                             
test "${MIREDO_MODPROBE_TUN}" = "yes" && modprobe tun                                                                                               

Reproducible: Always

[Comment 1 Michael Weber (RETIRED) 2010-08-31 11:21:27 UTC]

+*miredo-1.2.3-r1 (31 Aug 2010)
+
+  31 Aug 2010; Michael Weber <[e-mail]> -miredo-1.2.3.ebuild,
+  +miredo-1.2.3-r1.ebuild, files/miredo.rc:
+  Revision bump to fix bug #335297, thanks to Kai Krakow
+  <[e-mail]>


Index: files/miredo.rc
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-misc/miredo/files/miredo.rc,v
retrieving revision 1.1
diff -u -B -r1.1 miredo.rc
--- files/miredo.rc     3 May 2010 09:59:23 -0000       1.1
+++ files/miredo.rc     31 Aug 2010 11:20:29 -0000
@@ -10,8 +10,8 @@
 
 start() {
        ebegin "Starting Miredo"
-       [ "${MIREDO_MODPROBE_IPV6}" == "yes" ] && modprobe ipv6
-       [ "${MIREDO_MODPROBE_TUN}" == "yes" ] && modprobe tun
+       test "${MIREDO_MODPROBE_IPV6}" = "yes" && modprobe ipv6
+       test "${MIREDO_MODPROBE_TUN}" = "yes" && modprobe tun
        start-stop-daemon --start --quiet --exec /usr/sbin/miredo -- \
                ${MIREDO_OPTS}
        eend $?

[Comment 2 Thilo Bangert (RETIRED) (RETIRED) 2010-08-31 12:44:38 UTC]

thanks