Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 335265 - app-editors/emacs-vcs-24.0.9999: add imagemagick USE flag
Summary: app-editors/emacs-vcs-24.0.9999: add imagemagick USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-30 13:37 UTC by Ulrich Müller
Modified: 2010-09-02 14:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2010-08-30 13:37:49 UTC
*** tsdh (~user@p54AF0387.dip0.t-ipconnect.de) has joined channel #gentoo-lisp  
<tsdh> Hi.
<tsdh> Did anyone (=ulm ;-)) think about adding a USE flag to emacs-vcs-9999    
       for enabling imagemagick support?
<tsdh> There's already an imagemagick USE flag in use.desc, and the configure   
       option is --with-imagemagick.
<fe[nl]ix> what functionality does it enable ?
<fe[nl]ix> viewing images in buffers ?
<tsdh> fe[nl]ix: Yes, but with imagemagick you can also zoom and rotate.

I think that this patch would do it:

--- emacs-vcs-24.0.9999.ebuild
+++ emacs-vcs-24.0.9999.ebuild
@@ -30,3 +30,3 @@
 KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86 ~x86-fbsd"
-IUSE="alsa dbus gconf gif gpm gtk gzip-el hesiod jpeg kerberos m17n-lib motif png sound source svg tiff toolkit-scroll-bars X Xaw3d xft +xpm"
+IUSE="alsa dbus gconf gif gpm gtk gzip-el hesiod imagemagick jpeg kerberos m17n-lib motif png sound source svg tiff toolkit-scroll-bars X Xaw3d xft +xpm"
 RESTRICT="strip"
@@ -52,2 +52,3 @@
 		xpm? ( x11-libs/libXpm )
+		imagemagick? ( >=media-gfx/imagemagick-6.6.2 )
 		xft? (
@@ -154,3 +155,3 @@
 		myconf="${myconf} $(use_with tiff) $(use_with xpm)"
-		myconf="${myconf} $(use_with xft)"
+		myconf="${myconf} $(use_with imagemagick) $(use_with xft)"
 

However, I'm on travel this week and I've no way to properly test this here.
So I could take care of it next week at earliest. Fauli?
Comment 1 Tassilo Horn 2010-08-30 15:16:17 UTC
Hey, that patch is nearly literally the same I've posted at http://pastebin.ca/1929062. ;-)

WRT testing, I'm using emacs built with --with-imagemagick for nearly a week without problems.  It should not change anything at all unless a user activates it via calling (imagemagic-register-types).
Comment 2 Christian Faulhammer (RETIRED) gentoo-dev 2010-08-31 08:05:09 UTC
Will apply it to the ebuild soon.
Comment 3 Christian Faulhammer (RETIRED) gentoo-dev 2010-09-02 14:52:57 UTC
Added.