Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 334489 - >=dev-util/gtk-doc-1.13 has automagic dependency on syntax highlighters
Summary: >=dev-util/gtk-doc-1.13 has automagic dependency on syntax highlighters
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords: InVCS
: 338366 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-25 18:46 UTC by Ulrich Müller
Modified: 2010-11-14 15:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2010-08-25 18:46:34 UTC
configure checks for presence of "source-highlight", "highlight" and "vim", and in case one of them is found its path is embedded in /usr/bin/gtkdoc-fixxref.
From build.log:

   checking for source-highlight... no
   checking for highlight... no
   checking for vim... /usr/bin/vim

Therefore after "emerge vim; emerge gtk-doc; emerge -C vim" gtkdoc-fixxref will fail.

Please note that this is _not_ a dupe of bug 333313, as it happens with stable vim (7.2.442) too.
Comment 1 Pacho Ramos gentoo-dev 2010-08-26 09:25:01 UTC
I would suggest you to report this to upstream also if possible. Thanks :-)
Comment 2 Ulrich Müller gentoo-dev 2010-08-26 11:18:32 UTC
(In reply to comment #1)
> I would suggest you to report this to upstream also if possible. Thanks :-)

I can do of course. A hint from the Gnome team about what would be your preferred solution would be helpful, though.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-08-26 11:54:49 UTC
something like "--with-highlight=(none|vim|source-highlight|highlight|auto)" would be good
Comment 4 Nirbheek Chauhan (RETIRED) gentoo-dev 2010-09-02 17:24:13 UTC
For the record: A related problem was faced in bug 306569
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-22 17:00:19 UTC
*** Bug 338366 has been marked as a duplicate of this bug. ***
Comment 6 Juergen Rose 2010-09-23 12:10:39 UTC
Is there any progress in solving this bug? After removing glitz and if the doc USE flag ist, several packages e.g. glib, libbononoboui, etc fail to reemerge.
Comment 7 Juergen Rose 2010-09-24 08:26:21 UTC
media-gfx/gtkimageview-1.6.4 also fails to emerge because of missing /usr/bin/vim.
Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-09-24 08:55:01 UTC
don't bother reporting all failures, we know that any package using gtk-doc might fail due to this bug. What we need is a patch.
Comment 9 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-09-26 16:52:21 UTC
Attached a tentative patch to the upstream bug. Let's see what they say about it.
Comment 10 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-10-29 22:36:53 UTC
I'm about to commit the necessary changes to the ebuild, but I have a question I'd like to get feedback on, which highlighter should we pick. I'm opposed to exposing all of them through use flags or doing guess work in the ebuild. I wanted to go with source-highlight but it doesn't have sufficient keywording yet. Should we go with vim instead ?
Comment 11 Pacho Ramos gentoo-dev 2010-10-30 18:22:36 UTC
(In reply to comment #10)
> I'm about to commit the necessary changes to the ebuild, but I have a question
> I'd like to get feedback on, which highlighter should we pick. I'm opposed to
> exposing all of them through use flags or doing guess work in the ebuild. I
> wanted to go with source-highlight but it doesn't have sufficient keywording
> yet. Should we go with vim instead ?
> 

I also don't think having USE flags for each highlighter looks nice, but it would have the advantage of letting people (like me) to prevent installation of a new package (dev-util/source-highlight) as I will have app-editors/vim installed anyway :-/
Comment 12 Ulrich Müller gentoo-dev 2010-10-30 20:40:14 UTC
(In reply to comment #10)
> I'm about to commit the necessary changes to the ebuild, but I have a
> question I'd like to get feedback on, which highlighter should we pick.
> I'm opposed to exposing all of them through use flags or doing guess work
> in the ebuild. I wanted to go with source-highlight but it doesn't have
> sufficient keywording yet. Should we go with vim instead ?

The upstream package can work with either, so why don't you want to make it controllable by USE flags? An unconditional dependency on vim doesn't look right to me. (And it would also have the strange consequence that emacs would depend on vim, via gtk+ and gtk-doc. Last time we did such a thing we had an outcry from users ...)

Besides, isn't source-highlight the tool best suited for the job?
Comment 13 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-10-31 23:21:17 UTC
A use flag is needed to make sure you don't have to do guessing work in the ebuild to find what highlighter to select and I'm sure we'll get a couple of users complaining about highlighting dependency forced if we go with that.
Comment 14 Ulrich Müller gentoo-dev 2010-11-01 09:57:30 UTC
(In reply to comment #13)
> A use flag is needed to make sure you don't have to do guessing work in the
> ebuild to find what highlighter to select and I'm sure we'll get a couple of
> users complaining about highlighting dependency forced if we go with that.

Yeah, I'm all for USE flags here. (Reading my previous comment #12 again, I see that I didn't express it very clearly.)
Comment 15 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-11-14 15:45:03 UTC
+*gtk-doc-1.15-r2 (14 Nov 2010)
+
+  14 Nov 2010; Gilles Dartiguelongue <eva@gentoo.org>
+  -files/gtk-doc-1.10-no-m4.patch, -gtk-doc-1.11.ebuild,
+  -files/gtk-doc-1.11-fix-index-id-gen.patch,
+  -files/gtk-doc-1.11-quote-filenames-with-space.patch,
+  -files/gtk-doc-1.11-tests-fixes.patch, -gtk-doc-1.13-r2.ebuild,
+  -files/gtk-doc-1.13-fixxref-compat.patch,
+  -files/gtk-doc-1.13-scan-touch-module-overrides.patch,
+  +gtk-doc-1.15-r2.ebuild,
+  +files/gtk-doc-1.15-allow-selection-highlighter.patch, metadata.xml:
+  Fix automagic highlighting program detection, bug #334489. Handle
+  multi-slot python. Clean up old revisions.

Thanks for reporting.