Bug 33428 – FireHOL v1.159 suggested changes

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Costa Tsaousis 2003-11-13 15:23:11 UTC]

Hi,

I am the developer of FireHOL. I have a few suggestions for the firehol ebuild
(sorry for not taking care of this, but I am not yet so familiar with Gentoo):

1. FireHOL completely supports Gentoo out of the box. This means that the
src_compile() section in the ebuild should not search/replace anything.

2. I have verified every external component used by FireHOL and concluded
to this list of packages needed by FireHOL:

RDEPEND="app-shells/bash
        sys-apps/fileutils
        sys-apps/gawk
        sys-apps/grep
        sys-apps/iproute
        net-firewall/iptables
        sys-apps/less
        sys-apps/modutils
        sys-apps/net-tools
        sys-apps/procps
        sys-apps/sed
        sys-apps/sh-utils
        sys-apps/textutils
        sys-apps/util-linux"

I don't know if there is some policy regarding any of the above (note for
example modutils which might become module-init-tools in 2.6 kernels).
Anyway, the above list is the complete list of packages FireHOL depends on.

3. I suggest to put examples/client-all.conf as the default
/etc/firehol/firehol.conf,
but only if the later does not already exist (there is no need to have the
user etc-update the configuration for this file).

Regards,

Costa

(I have posted this to another CLOSED bug, but I don't know if you have received
it, so here it is again).

Reproducible: Always
Steps to Reproduce:

[Comment 1 Dominik Stadler (RETIRED) 2004-04-24 02:18:49 UTC]

I did a quick lock at your items, although I am not involved with networking/firewalls in Gentoo:

1. 
It seems that the developers of the ebuild decided to do a few replacements that
- move the firehol.conf script into a separate directory /etc/firehol instead of /etc directly
- the replacing of things from /sbin to /usr/sbin seems to be really unnecessary  and not doing anything anymore in the latest version 1.159

2.
The following dependencies are left after not listing a number of packages that are available on every gentoo-system by default (i.e. which are installed by "emerge system"):

RDEPEND="sys-apps/iproute
        net-firewall/iptables
        sys-apps/util-linux"

iproute2 and iptables are already listed. Therefore it seems that only util-linux is missing.

[Comment 2 Andreas Simon 2004-05-03 03:20:54 UTC]

But util-linux is part of 'emerge system'.

[Comment 3 Costa Tsaousis 2004-05-18 05:55:43 UTC]

Note that v1.191 has been released.

May I help for releasing a stable ebuild?

Costa

[Comment 4 Dominik Stadler (RETIRED) 2004-05-18 08:07:20 UTC]

Thanks for the offer, but there is already an ebuild in Bug 49822, I just need to get the time to add it and see if it also closes this Bug.

[Comment 5 Dominik Stadler (RETIRED) 2004-05-18 11:45:13 UTC]

Item 1 and 3 should be fixed with the new Version 1.191, which is available in Portage. Item 2 seems to be not an issue as all not-listed dependencies are always present on any Gentoo-System.