Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 33424 - valgrind-2.0.0 does not need patch; valgrind fails during compile
Summary: valgrind-2.0.0 does not need patch; valgrind fails during compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All All
: High normal
Assignee: Caleb Tennis (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-13 14:24 UTC by Steven Robertson
Modified: 2003-11-15 07:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Robertson 2003-11-13 14:24:38 UTC
valgrind-2.0.0.ebuild includes a patch from the previous valgrind prerelease which enables it to build on 2.6 series kernels.  This patch is no longer needed in the 2.0.0 version, and patching fails preventing the emerge from completing.  Commenting out the patch produced a fully-working valgrind on my 2.6 system.

Thanks!

Steven Robertson
Comment 1 James 2003-11-13 19:43:58 UTC
I agree. the patch is not needed. Without the patch entry in the .ebuild file, it emerges correctly, and runs.
The patch causes this: -
>>> emerge (3 of 4) dev-util/valgrind-2.0.0 to /
>>> md5 src_uri ;-) valgrind-2.0.0.tar.bz2
>>> Unpacking source...
>>> Unpacking valgrind-2.0.0.tar.bz2 to /var/tmp/portage/valgrind-2.0.0/work
 * Applying valgrind-configure.in-2.6.diff...
 
 * Failed Patch: valgrind-configure.in-2.6.diff!
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/valgrind-2.0.0/temp/valgrind-configure.in-2.6.diff-20517.out
 
 
!!! ERROR: dev-util/valgrind-2.0.0 failed.
!!! Function epatch, Line 354, Exitcode 0
!!! Failed Patch: valgrind-configure.in-2.6.diff!
Comment 2 Priit Laes (IRC: plaes) 2003-11-13 23:54:04 UTC
Confirmed. After commenting out the patch, emerged fine on my 2.6.0-test9 system...
Comment 3 Andreas Simon 2003-11-14 02:40:25 UTC
Valgrind still needs patching to make it work with kernel-2.6.
See bug report #32966.
Comment 4 Arve Knudsen 2003-11-14 03:37:35 UTC
I dont get it, dont developers test their ebuilds before integrating them with
the tree? I mean, just update the version and fingers crossed?
Comment 5 Christopher Rude 2003-11-15 01:52:35 UTC
The problem in bug #32966 is not present on for all people running 2.6. That bug is a build problem and the thought is (at least by me ;) that it might be due to nptl. 

The patch in this case is for the configure script, and is not needed becasue the config.in already contains the check for 2.6.
Comment 6 Caleb Tennis (RETIRED) gentoo-dev 2003-11-15 07:39:27 UTC
this was fixed yesterday.