Bug 333839 – net-misc/wget-1.12-r1: wget-1.12-sni.patch doesnt seem to properly support ipv6

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sergei Trofimovich (RETIRED) 2010-08-21 18:48:53 UTC]

This piece of code looks suspicious:

+bool
+is_ip_address (const char *name)
+{
+  const char *endp;
+
+  endp = name + strlen(name);
+  if (is_valid_ipv4_address(name, endp))
+    return true;
+#ifdef ENABLE_IPV6
+  if (is_valid_ipv4_address(name, endp))
+    return true;
+#endif
+  return false;
+}

I believe the real intention was to use
'is_valid_ipv6_address' under #ifdef ENABLE_IPV6.

[Comment 1 Sergei Trofimovich (RETIRED) 2010-08-21 18:49:30 UTC]

Created attachment 243929 [details, diff]
wget-1.12-sni.patch.patch

[Comment 2 SpanKY 2010-08-21 22:17:55 UTC]

thanks ... i sent your feedback upstream and updated the patch

http://sources.gentoo.org/net-misc/wget/files/wget-1.12-sni.patch?r1=1.1&r2=1.2