As the author, I hereby promise not to do anything that would make this difficult to maintain.
Created attachment 243815 [details] Ebuild
Created attachment 243817 [details] nagios-mode site file
Thank you for this contribution. Committed to Emacs overlay: <https://overlays.gentoo.org/proj/emacs/changeset/1515> Could you also provide us with a short test plan for the package? See here for examples: <https://overlays.gentoo.org/proj/emacs/wiki/test%20plans>
Created attachment 247008 [details] nagios-mode test suite Sure. I actually keep a test suite (test_suite.cfg) in the git repo at, http://michael.orlitzky.com/git/?p=nagios-mode.git;a=tree but I don't distribute it with the tarball (should I?). The typical instructions apply -- open the file, enable nagios-mode, and check that each of the tests in the file does what it says it should.
(In reply to comment #4) > Sure. I actually keep a test suite (test_suite.cfg) in the git repo at, > > http://michael.orlitzky.com/git/?p=nagios-mode.git;a=tree Thanks again. I'll attach this as a file to our "test plans" page. > but I don't distribute it with the tarball (should I?). That cannot harm. The ebuild could install it in /usr/share/doc/ then.
(In reply to comment #5) > > That cannot harm. The ebuild could install it in /usr/share/doc/ then. > Ok, updated: http://michael.orlitzky.com/code/releases/nagios-mode-0.3.tar.gz
Created attachment 279547 [details] Updated ebuild * Bumped to EAPI=4. * Added test_suite.cfg to DOCS. * Removed the SITEFILE declaration.
(In reply to comment #7) > * Removed the SITEFILE declaration. Why?
(In reply to comment #8) > (In reply to comment #7) > > * Removed the SITEFILE declaration. > > Why? Something must have changed; I'm rebuilding one of our nagios boxes and hit this yesterday: * Installing site initialisation file for GNU Emacs ... cp: cannot stat `/home/mjo/src/overlays/mjo-overlay/app-emacs/nagios-mode/files /50nagios-mode-gentoo.el': No such file or directory The eclass docs say it's optional, so I tried removing the SITEFILE declaration and that fixed the error.
Bumped to -r1 in Emacs overlay, with your changes. I've kept the SITEFILE though. It's about time to move this package to the Portage tree. Probably I won't add .cfg to auto-mode-alist though, since this is a very generic file suffix that might be used also for other than nagios files.
(In reply to comment #10) > Bumped to -r1 in Emacs overlay, with your changes. I've kept the SITEFILE > though. Ugh, of course. I don't think I knew what I was doing when I wrote the initial ebuild =) I copied the SITEFILE definition but didn't realize what it did; when I went to test the ebuild again recently, I forgot to add the sitefile to my overlay before testing. > It's about time to move this package to the Portage tree. Probably I won't add > .cfg to auto-mode-alist though, since this is a very generic file suffix that > might be used also for other than nagios files. Thanks, I agree with the *.cfg decision. I can proxy maintain if it would make your life easier.
Committed to Portage tree. Thanks again. (In reply to comment #11) > I can proxy maintain if it would make your life easier. Thanks for the offer. It looks like the package will be easy to maintain (it even can be installed with eclass default functions). So I think that proxy maintenance won't be needed.
