Bug 333707 – media-video/get-flash-videos claims to be 1.23 but is actually 1.21

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description monsieurvideo 2010-08-20 20:25:04 UTC]

Hi,

A user reported an issue which should have been fixed by 1.23, however it seems this ebuild uses an unofficial download location and is actually still offering 1.21.

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-video/get_flash_videos/get_flash_videos-1.23.ebuild?view=markup

Refers to: http://omploader.org/vNGdjYQ/ this is not something that we released.

Please use: http://github.com/monsieurvideo/get-flash-videos/tarball/v1.23 instead.

Thanks.



Reproducible: Always

[Comment 1 Diego Elio Pettenò (RETIRED) 2010-08-20 21:31:54 UTC]

omploader should be banned from SRC_URI entirely.

[Comment 2 Markos Chandras (RETIRED) 2010-08-20 22:26:05 UTC]

I fixed the SRC_URI
Sorry for the confusion. If only upstream provided actual tarballs instead of git tags

Anyway

[Comment 3 monsieurvideo 2010-08-20 22:43:17 UTC]

Technically we release a single script rather than a tarball, until I saw this ebuild I wasn't aware anyone took things straight from our git repo and built it for a distro. Once I've understood what this ebuild is doing I'll see if we can release what you want.

[Comment 4 Markos Chandras (RETIRED) 2010-08-20 22:54:10 UTC]

An ideal way is to provide a tarball with a single makefile+sources. The makefile should be a minimal as possible. Just remove all the script for project users. Finally the make file should build the manpage and the script like it does now


Thank you

[Comment 5 Michael Weber (RETIRED) 2010-08-24 22:25:25 UTC]

*** Bug 334305 has been marked as a duplicate of this bug. ***

[Comment 6 Michael Weber (RETIRED) 2010-08-24 22:26:05 UTC]

(In reply to comment #5)
> *** Bug 334305 has been marked as a duplicate of this bug. ***

Happened again :-(

[Comment 7 Markos Chandras (RETIRED) 2010-08-24 22:32:30 UTC]

 $ ./get_flash_videos -v
get_flash_videos version 1.22 (http://code.google.com/p/get-flash-videos/)

But
SRC_URI="http://github.com/monsieurvideo/get-flash-videos/tarball/v1.23 -> ${P}.tar.gz"

So blame upstream for not tagging code correctly

And since it seems that the actual code is 1.22 and NOT 1.23 I will drop 1.23 ebuild and bring 1.22 instead


@[e-mail]

Any suggestion on that please?

[Comment 8 monsieurvideo 2010-08-27 16:38:22 UTC]

Oops, sorry about that, seems like a bug in our migration to git, the code was actually v1.23 just it seems the version increment happened one commit after the tag. The tag is now in the correct place.

(BTW: The next version will be packaged using ExtUtils::MakeMaker so it will be more like a normal perl app.)

[Comment 9 Markos Chandras (RETIRED) 2010-08-27 17:17:06 UTC]

Please do not move tags around the code. This is quite annoying for packagers. You could have used another tag like 1.23.1 or so. Anyway. I remanifest the ebuild to match the latest checksum and I hope this will stay as it is from now on