Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 333547 - >=www-client/chromium-6.0.472.33 are missing h264 support in Gentoo
Summary: >=www-client/chromium-6.0.472.33 are missing h264 support in Gentoo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Chromium Project
URL: http://dev.chromium.org
Whiteboard:
Keywords:
: 338637 339129 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-20 02:44 UTC by Andy Wilkinson
Modified: 2011-06-29 01:10 UTC (History)
13 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
chromium-6.0.495.1 build log (08191934_chromium-build.log.gz,260.65 KB, application/x-gzip)
2010-08-20 02:45 UTC, Andy Wilkinson
Details
emerge --info (emerge.info,3.79 KB, text/plain)
2010-08-20 02:47 UTC, Andy Wilkinson
Details
ebuild for 6.0.472.41 with h264 support (chromium-6.0.472.41-r1.ebuild,6.85 KB, text/plain)
2010-08-27 04:55 UTC, Andy Wilkinson
Details
ebuild for 7.0.503.1 with h264 support (chromium-7.0.503.1-r1.ebuild,6.91 KB, text/plain)
2010-08-27 04:59 UTC, Andy Wilkinson
Details
ebuild for 7.0.503.1-r1 with h264 support (chromium-7.0.503.1-r1.ebuild,6.85 KB, text/plain)
2010-09-14 04:18 UTC, Andy Wilkinson
Details
ebuild for 6.0.472.55 with h264 (chromium-6.0.472.55.ebuild,6.90 KB, text/plain)
2010-09-14 05:19 UTC, Bailey Kong
Details
chromium-7.0.517.5.ebuild.patch (chromium-7.0.517.5.ebuild.patch,546 bytes, patch)
2010-09-15 09:52 UTC, Zac Medico
Details | Diff
Patch against 7.0.517.24 (chromium-7.0.517.24.ebuild.patch,697 bytes, patch)
2010-10-02 09:39 UTC, Dennis Schridde
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Wilkinson 2010-08-20 02:44:13 UTC
All ebuilds for chromium beta and dev channel releases after 6.0.472.33 break h264 <video> support.  I have tested the same versions from chromium buildbot in ubuntu, and there it is fixed per http://code.google.com/p/chromium/issues/detail?id=50678.  By that, I suppose it to be a Gentoo issue.

Reproducible: Always

Steps to Reproduce:
1.  Unmask and emerge =www-client/chromium-6.0.495.1
2.  h264 support is disabled in chromium

Actual Results:  
h264 support is disabled in recent versions of chromium on Gentoo.

Expected Results:  
h264 support is enabled in recent versions on Ubuntu and Windows.
Comment 1 Andy Wilkinson 2010-08-20 02:45:52 UTC
Created attachment 243645 [details]
chromium-6.0.495.1 build log
Comment 2 Andy Wilkinson 2010-08-20 02:47:07 UTC
Created attachment 243647 [details]
emerge --info
Comment 3 Andy Wilkinson 2010-08-26 14:18:28 UTC
This is still an issue in 7.0.503.1.

I am happy to do anything I can to help troubleshoot or test; however I don't have the experience with Chromium to know what to do on my own.  Chromium Herd, please feel free to give me any direction you can that might help to isolate this issue.
Comment 4 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-08-26 14:50:46 UTC
Ideally we should be building with system ffmpeg (-Duse_system_ffmpeg=1). That would give us h264 support if system ffmpeg has it. Another option would be adding a bindist flag to the ebuild and changing ffmpeg branding to one that supports h264 if the bindist flag is not enabled.
Comment 5 Andy Wilkinson 2010-08-27 04:55:21 UTC
Created attachment 244843 [details]
ebuild for 6.0.472.41 with h264 support

Okay... the better part of a day spent recompiling chromium over and over, and I have two solution-ish things.

This is the first: h264 enabled in the bundled ffmpeg.  The issue was a missing configure flag: -Dproprietary_codecs=1.  Maybe this should go behind a -bindist or something so that it doesn't happen if people are building a bindist?  I'm not an ebuilder or a licenser or anything, so I don't know, but this makes the latest beta work with h264, without requiring any trunk builds.
Comment 6 Andy Wilkinson 2010-08-27 04:59:12 UTC
Created attachment 244845 [details]
ebuild for 7.0.503.1 with h264 support

The other solution (probably more in line with what Gentoo wants) is h264 support with system ffmpeg.  The bad thing is that chromium requires a new feature of ffmpeg that is not included in the 0.6 release (or any since), so here in Gentooland that means unmasking and using ffmpeg-9999, which I've added as a DEPEND.

So, that explains the issue to me.  The solution I used in the 6.0.472.41 ebuild should theoretically work on all of the ebuilds since...  As long as we are using the bundled libs while we wait on ffmpeg, is there a reason not to add that conf flag to the ebuilds?
Comment 7 Matt 2010-09-08 23:37:36 UTC
thanks for the ebuild for chromium 7 !

there's however a typo:

DEPEND="${RDEPEND}
	dev-lang/perl
	>=dev-util/gperf-3.0.3
	>=dev-util/pkgconfig-0.23
	>=gnome-base/gnome-keyring-2.28.2
	sys-devel/flex"
	~media-video/ffmpeg-9999

should be

DEPEND="${RDEPEND}
	dev-lang/perl
	>=dev-util/gperf-3.0.3
	>=dev-util/pkgconfig-0.23
	>=gnome-base/gnome-keyring-2.28.2
	sys-devel/flex
	~media-video/ffmpeg-9999"

mark the quotation marks at the end of ffmpeg instead of flex :)
Comment 8 darkbasic 2010-09-13 15:17:46 UTC
Is myconf="${myconf} -Dproprietary_codecs=1" the only difference with the official ebuild?
Because it still doesn't work...
Comment 9 Andy Wilkinson 2010-09-14 04:18:21 UTC
Created attachment 247210 [details]
ebuild for 7.0.503.1-r1 with h264 support

No, that is not the only difference.  I've uploaded a new version that more obviously highlights the differences, which are mainly:

# Use system ffmpeg and build proprietary codecs.
	myconf="${myconf} -Duse_system_ffmpeg=1
		-Dbuild_ffmpegsumo=0
		-Dproprietary_codecs=1"

and

# Chromium looks for these in its folder
	# See media_posix.cc and base_paths_linux.cc
	dosym /usr/$(get_libdir)/libavcodec.so.52 "/usr/$(get_libdir)/chromium-browser"
	dosym /usr/$(get_libdir)/libavformat.so.52 "/usr/$(get_libdir)/chromium-browser"
	dosym /usr/$(get_libdir)/libavutil.so.50 "/usr/$(get_libdir)/chromium-browser"

There are also a couple of doexe lines to do with ffmpegsumo that need to go away now that we aren't building it.

Previously, I was doing the dosym lines at the end wrong, which broke it, because for some reason chrome doesn't look for for libav* in libdir.

This version should really actually work.
Comment 10 Bailey Kong 2010-09-14 05:19:44 UTC
Created attachment 247211 [details]
ebuild for 6.0.472.55 with h264
Comment 11 Bailey Kong 2010-09-14 05:22:24 UTC
The new ebuild I uploaded uses the bundled ffmpeg but enables h264 support by adding "-Dproprietary_codecs=1 -Dffmpeg_branding=Chrome". This is useful for people who aren't too keen on using ffmpeg-9999.
Comment 12 darkbasic 2010-09-14 08:48:37 UTC
>>> Configuring source in /var/tmp/portage/media-video/ffmpeg-9999-r1/work/ffmpeg-9999 ...
Unknown option "--enable-avfilter-lavf".
See ./configure --help for available options.
Comment 13 Michel Lang 2010-09-14 16:40:28 UTC
chromium-7.0.503.1-r1.ebuild with the line
  myconf="${myconf} -Dproprietary_codecs=1 -Dffmpeg_branding=Chrome"
added also works and provides hassle-free h264 support. 

I would appreciate this going into the official ebuild (with bindist flag).
Comment 14 Zac Medico gentoo-dev 2010-09-15 09:52:36 UTC
Created attachment 247443 [details, diff]
chromium-7.0.517.5.ebuild.patch

This patch should do the equivalent of the the one attached in comment #10. I've tested it with chromium-7.0.517.5 and it seems to work fine, aside from the audio being slightly out of synch. This is my first build to have html5 youtube videos working with both h264 and webm, so I'm pretty happy with it.
Comment 15 Bernard Cafarelli gentoo-dev 2010-09-27 11:41:27 UTC
*** Bug 338637 has been marked as a duplicate of this bug. ***
Comment 16 Bernard Cafarelli gentoo-dev 2010-09-30 14:21:03 UTC
*** Bug 339129 has been marked as a duplicate of this bug. ***
Comment 17 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-09-30 14:44:31 UTC
I'd like to try to use system ffmpeg first, waiting for an update of the ffmpeg package in Gentoo.
Comment 18 Dennis Schridde 2010-10-02 09:39:11 UTC
Created attachment 249276 [details, diff]
Patch against 7.0.517.24

(In reply to comment #14)
> Created an attachment (id=247443) [details]
> chromium-7.0.517.5.ebuild.patch
Patch adapted to 7.0.517.24, the current beta ebuild in tree.
Works very well here.
Comment 19 Dennis Schridde 2010-10-04 19:51:42 UTC
After my patch http://html5test.com/ still says that MPEG-4 (container?) as well as PCM support is missing. Does anyone know how to fix that?
Comment 20 darkbasic 2010-10-04 19:56:02 UTC
What about using system ffmpeg?
Comment 21 darkbasic 2010-10-10 14:15:33 UTC
Does media-video/ffmpeg-0.6_p25423 work with Chromium?
Comment 22 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-10-11 09:47:01 UTC
This should be fixed in chromium-7.0.544.0-r2. Enjoy!
Comment 23 Sylvain BERTRAND 2011-06-28 23:03:29 UTC
h264 seems gone in 14.0.797.0 

Anyone?
Comment 24 Mike Gilbert gentoo-dev 2011-06-29 01:10:35 UTC
(In reply to comment #23)
> h264 seems gone in 14.0.797.0 
> 
> Anyone?

Paweł switched it to use the bundled ffmpeg again. See bug 371931.