Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 333219 - [PATCH] games-emulation/sdlmame: USE-flags to remove debugging and gconf/gtk dependency
Summary: [PATCH] games-emulation/sdlmame: USE-flags to remove debugging and gconf/gtk ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-17 19:36 UTC by Martin Väth
Modified: 2010-08-17 19:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch for IUSE="+debug" in the ebuild (sdlmame-0.136.ebuild.patch,633 bytes, patch)
2010-08-17 19:37 UTC, Martin Väth 		Details | Diff
Patch for the makefile; needed by the new ebuild in files/nodebug.patch (nodebug.patch,952 bytes, patch)
2010-08-17 19:38 UTC, Martin Väth 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2010-08-17 19:36:19 UTC 
One of the most annoying things of sdlmame is the gconf dependency.
If one builds it without debugging support, not only this dependency is
unneeeded, but also the gtk+ dependency can be dropped.
Therefore, it would be nice to have a USE-flag for it.
I attach a corresponding patch for the ebuild and for a makefile.
Comment 1 Martin Väth 2010-08-17 19:37:15 UTC 
Created attachment 243371 [details, diff]
Patch for IUSE="+debug" in the ebuild
Comment 2 Martin Väth 2010-08-17 19:38:07 UTC 
Created attachment 243373 [details, diff]
Patch for the makefile; needed by the new ebuild in files/nodebug.patch
Comment 3 SpanKY gentoo-dev 2010-08-17 19:47:47 UTC 
general comments:
 - keep IUSE sorted
 - no need for the einfo: use debug && epatch
 - patches should start with ${P}-

the patch looks useful and could be sent upstream ...
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2010-08-17 19:58:48 UTC 
in portage.  thanks for the bug report and patch.