Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 333029 - media-sound/shell-fm support EAPI=3, add ~amd64-linux
Summary: media-sound/shell-fm support EAPI=3, add ~amd64-linux
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-16 16:14 UTC by Nathan Phillip Brink (binki) (RETIRED)
Modified: 2010-08-18 21:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Phillip Brink (binki) (RETIRED) gentoo-dev 2010-08-16 16:14:38 UTC 
The shell-fm ebuild is written as an EAPI=2 ebuild, but nothing needs to be changed to set it to EAPI=3. The shell-fm Makefile defines a variable called PREFIX which is used during ``make install'' only. However, src_install() doesn't call emake install and thus PREFIX doesn't need to be set.

I tested that the shell-fm ebuild works on Gentoo Prefix on an ubuntu-amd64 system, so moving the ebuild to EAPI=3 and adding the ~amd64-linux keyword would be great :-).

--- a/media-sound/shell-fm/shell-fm-0.7.ebuild  Mon Aug 16 09:25:30 2010 -0400
+++ b/media-sound/shell-fm/shell-fm-0.7.ebuild  Mon Aug 16 09:50:39 2010 -0400
@@ -5,1 +5,1 @@
-EAPI=2
+EAPI=3
@@ -15,1 +15,1 @@
-KEYWORDS="~amd64 ~ppc ~x86"
+KEYWORDS="~amd64 ~amd64-linux ~ppc ~x86"
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2010-08-17 09:15:54 UTC 
go ahead
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-08-18 21:05:47 UTC 
done.

I didn't move to EAPI=3 because it wasn't needed.