Bug 33287 – Don't error on unadded backup~ files.

• Status: RESOLVED WONTFIX
• Product: Portage Development

[Description Luke-Jr 2003-11-12 01:31:30 UTC]

Files ending with a ~ are usually considered backups... Repoman shouldn't error
if they're not in CVS.

Reproducible: Always
Steps to Reproduce:

[Comment 1 Nicholas Jones (RETIRED) 2003-12-22 23:53:08 UTC]

My EXTREME objection to this is that such files are created by diff/patch
when it does fuzzy patching. Your CVS tree should be a clean repository
that matches identically with what is in distribution. If it's in your
tree, it should either be pushed out or removed. Cruft is bad.

[Comment 2 Alec Warner (RETIRED) 2005-07-30 07:25:57 UTC]

Any opinions on this?  Should the CVS tree be clean as a thistle, or should 
Repoman ignore the backup files remaining in it?

I'm personally with carpaski on this such that with ~ in the CVS tree someone 
might erronously commit them.

[Comment 3 Jason Stubbs (RETIRED) 2005-07-30 07:54:00 UTC]

I'm in EXTREME agreement ;) 

[Comment 4 Luke-Jr 2005-07-30 17:16:27 UTC]

wouldn't it make more sense to reserve the error for if the ~ files are 'cvs 
add'ed and ignore them otherwise? 

[Comment 5 Jason Stubbs (RETIRED) 2005-07-30 21:16:24 UTC]

No because creating the Manifest should not be sensitive to 
CVS/Subversion/whatever and the Manifest must cover all existing files. 

[Comment 6 Luke-Jr 2005-07-31 10:10:34 UTC]

How is the non-existence of backup files any better than their absence in the 
Manifest.