Bug 332813 – sys-apps/baselayout-1: rc-status has an extra space at the end of two print_msg lines

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Milos Ivanovic 2010-08-15 08:10:54 UTC]

In /bin/rc-status:

line 227: print_msg "${service}" "${GOOD}" 'started '
                                                   ^^ --- unnecessary space character

line 229: print_msg "${service}" "${BAD}" 'stopped '

                                                  ^^ --- unnecessary space character

This leads to an output such as [ started  ] as opposed to [ started ].
Other lines that have similar output do not have this character at the end. Could they please be removed, for the sake of consistency?

Thank you.

Reproducible: Always

[Comment 1 William Hubbs 2010-08-15 16:19:55 UTC]

Please attach the output from emerge --info and reopen this bug once
that is done.

Thanks,

William

[Comment 2 SpanKY 2010-08-15 16:55:04 UTC]

not a bug, so no need

[Comment 3 SpanKY 2010-08-15 16:56:13 UTC]

enough spacing is provided for the longest message so things are always in line

[ started  ]
[ inactive ]
[ stopped  ]
[ stopping ]
[ starting ]
[ broken   ]

[Comment 4 Milos Ivanovic 2010-08-16 07:17:32 UTC]

Ah, I see -- I missed the others, sorry. It's rather unfortunate though, considering you're mostly going to see only [ started  ].

[Comment 5 SpanKY 2010-08-16 12:14:57 UTC]

i agree, but most of the time is spent on scanning, so in order to calculate the required space, you need to do the whole scan.  so today you get little pauses between each message, but with that algo you get one long pause and then a dump of everything.  and it's more complicated ;).

[Comment 6 Milos Ivanovic 2010-08-17 04:50:07 UTC]

That's true :) Thanks for looking in on it.