RDEPEND gnome? ( >=gnome-base/gnome-keyring-2.28.2 ) DEPEND >=gnome-base/gnome-keyring-2.28.2 depend has unconditional gnome-keyring deps. this looks correct if use gnome; then myconf="${myconf} -Dlinux_link_gnome_keyring=1" else # TODO: we should also disable code trying to dlopen # gnome-keyring in that case. myconf="${myconf} -Dlinux_link_gnome_keyring=0" fi this should be conditional to gnome flag # Install GNOME default application entry (bug #303100). dodir /usr/share/gnome-control-center/default-apps insinto /usr/share/gnome-control-center/default-apps doins "${FILESDIR}"/chromium.xml
(In reply to comment #0) > depend has unconditional gnome-keyring deps. According to bug 324517 and http://code.google.com/p/chromium/issues/detail?id=12351#c29, this is correct.
maybe, need to check if they changed it now. anyhow RDEPEND is wrong.
(In reply to comment #2) > maybe, need to check if they changed it now. I think there is no change here. > anyhow RDEPEND is wrong. Why do you think so? I agree it could be confusing, but I think it's correct.
if it's a strict compile time dependency it should not be conditional to the gnome USE flag. what i mean, that line is totally useless, if oyu add or not the gnome flag you will have the DEPEND to force the keyring package to be installed
i saw the use flag was renamed but still DEPEND/RDEPEND deps. need to check if it's possibile to keep as chromium-5 without compile time keyring deps
Hi. Could you add virtual/perl-version to DEPEND please? Thanks. Can't locate version.pm in @INC (@INC contains: /tmp/portage/www-client/chromium-5.0.375.127/work/chromium-5.0.375.127/third_party/WebKit/WebCore/bindings/scripts /etc/perl /usr/lib64/perl5/vendor_perl/5.8.8/x86_64-linux /usr/lib64/perl5/vendor_perl/5.8.8 /usr/lib64/perl5/vendor_perl /usr/lib64/perl5/site_perl/5.8.8/x86_64-linux /usr/lib64/perl5/site_perl/5.8.8 /usr/lib64/perl5/site_perl /usr/lib64/perl5/5.8.8/x86_64-linux /usr/lib64/perl5/5.8.8 /usr/local/lib/site_perl .) at /usr/lib64/perl5/vendor_perl/5.8.8/Text/Balanced.pm line 13. BEGIN failed--compilation aborted at /usr/lib64/perl5/vendor_perl/5.8.8/Text/Balanced.pm line 13. Compilation failed in require at /usr/lib64/perl5/5.8.8/Switch.pm line 58. BEGIN failed--compilation aborted at /usr/lib64/perl5/5.8.8/Switch.pm line 58. Compilation failed in require at /tmp/portage/www-client/chromium-5.0.375.127/work/chromium-5.0.375.127/third_party/WebKit/WebCore/dom/make_names.pl line 38.
Fixed both issues in chromium 7.0.503.1-r1 and above. Thanks!
(In reply to comment #7) > Fixed both issues in chromium 7.0.503.1-r1 and above. Thanks! > Hi, I've always compiled chromium without any issue so I don't think that adding a dependency on virtual/perl-version is really needed. I'm no perl developer but judging from that error message it's seems to me that the problem is not in chromium dependencies but in the dependencies of virtual/perl-Text-Balanced (or perl-core/Text-Balanced). perl 5.8.8 provides a version (1.95) that doesn't seem to need version.pm, did Yuri install 2.0.0 or 2.02 from portage? If this is the case those packages should be fixed, not chromium.
Sorry for the false alarm, it was related to Text-Balanced, of course. Somehow, perl-version got deleted on my machine during summer cleanup. Text-Balanced-2.0.0 (which I have here installed) indeed properly depends on perl-version. Now I've tested both with and without perl-version installed and no errors were reported. Looks like some perl packages got updated when I installed perl-version and I can't reproduce that build error now. I don't have that old build log either. :) This pretty much leaves us to revert the dependency on perl-version. Thanks for worries, I didn't expect it would go straight into commit in 1 day. ;) (In reply to comment #8) > (In reply to comment #7) > > Fixed both issues in chromium 7.0.503.1-r1 and above. Thanks! > > > > Hi, I've always compiled chromium without any issue so I don't think that > adding a dependency on virtual/perl-version is really needed. > > I'm no perl developer but judging from that error message it's seems to me that > the problem is not in chromium dependencies but in the dependencies of > virtual/perl-Text-Balanced (or perl-core/Text-Balanced). perl 5.8.8 provides a > version (1.95) that doesn't seem to need version.pm, did Yuri install 2.0.0 or > 2.02 from portage? > > If this is the case those packages should be fixed, not chromium. >
