Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 33219 - AMD64 patch and ebuild change for x11-libs/wxGTK-2.4.2
Summary: AMD64 patch and ebuild change for x11-libs/wxGTK-2.4.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-11 06:09 UTC by Kris Kersey (RETIRED)
Modified: 2003-11-14 08:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to wxGTK-2.4.2. Fixes bugs as described in original comments. (wxGTK-2.4.2-cleanup.patch,30.39 KB, patch)
2003-11-11 06:12 UTC, Kris Kersey (RETIRED)
Details | Diff
Ebuild diff ffor wxGTK-2.4.2.ebuild. (wxGTK-2.4.2.ebuild.diff,757 bytes, patch)
2003-11-11 06:14 UTC, Kris Kersey (RETIRED)
Details | Diff
Remove removal of unused vars from the original patch. (wxGTK-2.4.2-cleanup.patch,17.74 KB, patch)
2003-11-11 08:02 UTC, Kris Kersey (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kris Kersey (RETIRED) gentoo-dev 2003-11-11 06:09:47 UTC
The attached patch is designed to make wxGTK compile without warning on AMD64.  Although some of the changes are trivial, (including unused variable comments, etc.) some are needed (such as casting errors and even a gtk2 fix).  I will not claim that all of my fixes are pretty but they all appear to work and if you look through what I had to work with you'd understand why.  I will submit this patch to the authors and try to get them to fix their code "more correctly".
Comment 1 Kris Kersey (RETIRED) gentoo-dev 2003-11-11 06:12:02 UTC
Created attachment 20583 [details, diff]
Patch to wxGTK-2.4.2.  Fixes bugs as described in original comments.
Comment 2 Kris Kersey (RETIRED) gentoo-dev 2003-11-11 06:12:40 UTC
Comment on attachment 20583 [details, diff]
Patch to wxGTK-2.4.2.  Fixes bugs as described in original comments.

You could rename this to -amd64 if you'd like to be a little more specific.
Comment 3 Kris Kersey (RETIRED) gentoo-dev 2003-11-11 06:14:07 UTC
Created attachment 20584 [details, diff]
Ebuild diff ffor wxGTK-2.4.2.ebuild.

Applies attachement 20583.
Comment 4 Kris Kersey (RETIRED) gentoo-dev 2003-11-11 08:02:34 UTC
Created attachment 20593 [details, diff]
Remove removal of unused vars from the original patch.

Leave unused variables in the source.  They don't hurt anything in there
and
could hurt something by removing them.
Comment 5 Alastair Tse (RETIRED) gentoo-dev 2003-11-13 03:24:53 UTC
have you submitted this patch upstream as well? seems like something that should also be included upstream
Comment 6 Brad House 2003-11-14 08:39:59 UTC
ok, done, thanks