Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 331921 - Clarify what PV represents in devmanual
Summary: Clarify what PV represents in devmanual
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 19:28 UTC by Petteri Räty (RETIRED)
Modified: 2010-10-17 09:46 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (0001-More-details-about-PV.-Bug-331921.patch,948 bytes, patch)
2010-10-16 13:33 UTC, Markos Chandras (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2010-08-09 19:28:33 UTC
19:26 <@ferringb> Halcy0n: can you clarify the policy documentation for this by chance?

19:26 <@ferringb> specifically "don't make 2.6.5 be in reality 2.6.6" ?

19:27 <@Halcy0n> ferringb: We can make it more clear in devmanual.
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2010-08-11 17:20:07 UTC
Copying from

http://devmanual.gentoo.org/ebuild-writing/variables/index.html

PV	Package version (excluding revision, if any), for example 6.3.

How is that not clean enough? Should we change it to "Package *official upstream* version" ?
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2010-08-11 17:30:33 UTC
(In reply to comment #1)
> Copying from
> 
> http://devmanual.gentoo.org/ebuild-writing/variables/index.html
> 
> PV      Package version (excluding revision, if any), for example 6.3.
> 

The idea is to provide instructions after what happened in bug 330667.

Comment 3 Markos Chandras (RETIRED) gentoo-dev 2010-10-16 13:33:37 UTC
Created attachment 250859 [details, diff]
proposed patch

Review this patch please or I will commit it in 72 hours
Comment 4 Petteri Räty (RETIRED) gentoo-dev 2010-10-16 20:48:10 UTC
(In reply to comment #3)
> Created an attachment (id=250859) [details]
> proposed patch
> 
> Review this patch please or I will commit it in 72 hours
> 

How about:

This should actually reflect the upstream versioning scheme
-->
It should reflect the upstream versioning scheme
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2010-10-17 00:55:11 UTC
Noted. Anything else?
Comment 6 Torsten Veller (RETIRED) gentoo-dev 2010-10-17 05:57:31 UTC
"It should reflect the upstream versioning scheme."

Isn't this sufficient?


"Patched versions should make use of _pX suffix to state clearly the existence of additional patches."

Adding _pX and fixing MY_PV and S for minor patches?
I don't think this helps.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2010-10-17 07:58:48 UTC
(In reply to comment #6)
> "It should reflect the upstream versioning scheme."
> 
> Isn't this sufficient?

It is.  Please make it so.
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2010-10-17 09:46:12 UTC
Fixed