Bug 33143 – New ebuild for xmms-mp3cue plug-in

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alexandre Veyrenc 2003-11-10 05:23:58 UTC]

This is an ebuild for the xmms mp3cue plug-in. Tested on a x86 platform and
working fine.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Alexandre Veyrenc 2003-11-10 05:25:08 UTC]

Created attachment 20517 [details]
ebuild for media-plugins/xmms-mp3cue

[Comment 2 Alexandre Veyrenc 2003-11-10 05:29:28 UTC]

This work is released under the GPL. Please add the necessary headers (Gentoo
copyright stuff, etc.) if this ebuild is moved to portage tree.
Have a nice day.

[Comment 3 Jeremy Huddleston (RETIRED) 2004-01-27 01:20:47 UTC]

I am delaying addition of this package pending a response from the package's author re: a segfault... here's the email I sent:

Hi,I was testing out your xmms-mp3cue plugin for inclusion in gentoo linux, and I've run into a showstopper bug.  I am using xmms 1.2.9-pre1, so that may be related.  The problem occurs when right clicking in the'mp3cue playlist' window and selecting 'import cue sheet'.  If the xmms playlist is empty, this action causes xmms to segfault.  Unfortunately, I can't get a full bt because when I test this segfaultthrough gdb, it locks up my wm on the segfault... so all I have is thisinfo for where the segfault occured:

0x4166ec76 in get_cue_name(char*) () from/usr/lib/xmms/General/libmp3cue.so

Thanks,
Jeremy

[Comment 4 Alexandre Veyrenc 2004-01-27 06:03:48 UTC]

Created attachment 24482 [details, diff]
Patch to fix the import cue bug

[Comment 5 Alexandre Veyrenc 2004-01-27 06:06:41 UTC]

Created attachment 24483 [details]
New ebuild that takes the patch into account

This ebuild uses the import cue patch.
Tested and working fine with XMMS 1.27

[Comment 6 Jeremy Huddleston (RETIRED) 2004-01-27 10:28:05 UTC]

that patch doesn't fix the problem, it just causes xmms to not segfault by jumping out.  It now doesn't load the cue sheet in the xmms playlist.

I'll wait a few days for the author to respond, and if I get no response, I'll try looking into it more also.

[Comment 7 Alexandre Veyrenc 2004-01-28 07:49:49 UTC]

You're right, the import cue function doesn't put the cue sheet in the xmms playlist. That's just because it's its the normal behavior.
The Windows version of the plug-in (the one made by John Dee) behaves like this :
- WinAMP playlist should be empty
- You import a cue sheet in the plug-in -> the plug-in displays the cue list
- You double click on a track in the cue list (in the plug-in window) -> the plug-in asks you to choose the corresponding audio file.
- You select this file -> the playback starts

The bug occured because the plugin wanted to make a suggestion about the cue sheet filename. For instance, if you have file.mp3 in the XMMS playlist, the plugin suggests file.cue. If the playlist is empty, my patch just tells the plugin to make an empty suggestion.

With this patch, the xmms-mp3cue plugin behaves like its Windows counterpart and doesn't crash XMMS, so I think it's good. Please tell me if I'm wrong (of course the author could patch it himself, that would be even better).

[Comment 8 Jeremy Huddleston (RETIRED) 2004-02-12 03:48:22 UTC]

Alright... it's in portage.