Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 331039 - media-libs/giblib-1.2.4 should use EAPI-2 for its USE dependency
Summary: media-libs/giblib-1.2.4 should use EAPI-2 for its USE dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
: 359055 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-03 13:47 UTC by William Keaney
Modified: 2012-10-27 18:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updates ebuild to EAPI-2 and adds USE dependency (giblib-1.2.4.deps.patch,717 bytes, patch)
2010-08-03 13:57 UTC, William Keaney
Details | Diff
build.log (build.log,1.84 KB, text/plain)
2010-08-03 15:51 UTC, William Keaney
Details

Note You need to log in before you can comment on or make changes to this bug.
Description William Keaney 2010-08-03 13:47:24 UTC
giblib depends on media-libs/imlib2 with USE="X", but doesn't check this dependency until the src_unpack() phase.
This causes Portage to complete dependency resolution, then fail during src_unpack().

Reproducible: Always

Steps to Reproduce:
1. USE="-X" emerge media-libs/imlib2
2. emerge -av media-libs/giblib

Actual Results:  
giblib's dependency on media-libs/imlib2 is satisfied, so building continues.
It then fails in the src_unpack phase, asking the user to re-emerge Imlib2 with USE="X"

Expected Results:  
Dependencies should be in DEPEND, not in src_unpack().

Attaching a patch in a moment.
Comment 1 William Keaney 2010-08-03 13:57:10 UTC
Created attachment 241241 [details, diff]
Updates ebuild to EAPI-2 and adds USE dependency
Comment 2 Michael Weber (RETIRED) gentoo-dev 2010-08-03 15:44:50 UTC
Hi,

no need to do the check in src_unpack, use EAPI-2's src_prepare.
No need to do the check, portage assures +X on this dep.

Anyway, do you have a build.log displaying the error?

Michael
Comment 3 William Keaney 2010-08-03 15:51:31 UTC
Created attachment 241255 [details]
build.log

My patch removes the check from src_unpack, and instead adds DEPEND=">=media-libs/imlib2-1.0.3[X]", so I'm not sure what your comment is in reference to.
Comment 4 SpanKY gentoo-dev 2011-04-15 08:55:20 UTC
*** Bug 359055 has been marked as a duplicate of this bug. ***
Comment 5 Pacho Ramos gentoo-dev 2012-10-27 18:38:21 UTC
fixed in 1.2.4-r1