modplugplay has (thankfully) been taken over by a new maintainer now, and a new release has been made. Also included is modplug123, which is the same program, but using the AO interface rather than OSS. Which is a lot nicer. The code's mostly unchanged (still pretty ugly,) but it works better than the current modplugplay in the tree. It has been renamed modplug-tools, as the package now contains two players. I suggest we rename media-sound/modplugplay to media-sound/modplugtools , and update the ebuild to reflect the new location and build info. I'll attach an ebuild momentarily. Ideally we could think about ao / oss use flags to enable / disable modplug123 or modplugplay, but for now the attached ebuild is still a big improvement on what's in the tree.
Created attachment 241139 [details] ebuild for modplugtools-0.5.0
*modplugtools-0.5.0 (02 Aug 2010) 02 Aug 2010; Samuli Suominen <ssuominen@gentoo.org> +modplugtools-0.5.0.ebuild: Initial commit wrt #330897 by Nick White.
Created attachment 241141 [details] patch to fix buffer overflow Did I mention that the code was ugly ;-) This patch fixes a buffer overflow with file paths > 41 characters. I sent it to the maintainer, so I expect it'll be included in the next release. Ebuild using this will follow in a moment.
Created attachment 241145 [details] ebuild for modplugtools-0.5.0 [using buffer overflow patch] Ebuild which applies the above patch. Note this overflow also exists in the current version of modplugplay in the tree.
(In reply to comment #2) > *modplugtools-0.5.0 (02 Aug 2010) > > 02 Aug 2010; Samuli Suominen <ssuominen@gentoo.org> > +modplugtools-0.5.0.ebuild: > Initial commit wrt #330897 by Nick White. Wow, that was fast; thanks! Reopening so we can include the patch just attached too.
(In reply to comment #5) > Wow, that was fast; thanks! Reopening so we can include the patch just attached > too. Closing again, the issue is fixed in the new version - see bug 331195
