Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 32990 - gameswrapper in games.eclass doesn't return status of cmd
Summary: gameswrapper in games.eclass doesn't return status of cmd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-08 01:51 UTC by Mr. Bones. (RETIRED)
Modified: 2003-11-12 14:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mr. Bones. (RETIRED) gentoo-dev 2003-11-08 01:51:37 UTC 
dogamesbin blah || die "dogamesbin failed" doesn't die like it should.
Comment 1 SpanKY gentoo-dev 2003-11-08 07:44:18 UTC 
does this patch fix it ?
--- /usr/portage/eclass/games.eclass.orig   2003-11-04 02:35:07.000000000
-0500
+++ /usr/portage/eclass/games.eclass    2003-11-08 10:39:09.000000000 -0500
@@ -69,7 +69,9 @@
        into ${GAMES_PREFIX}
        local cmd=$1; shift
        ${cmd} "$@"
+       local ret=$?
        into ${oldtree}
+       return ${ret}
 }

 dogamesbin() { gameswrapper ${FUNCNAME/games} "$@"; }
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2003-11-08 19:28:55 UTC 
yeah, that works great.  Please add that to games.eclass or let me know
and I'll add it.  Thanks.
Comment 3 SpanKY gentoo-dev 2003-11-10 12:04:57 UTC 
in cvs now
Comment 4 SpanKY gentoo-dev 2003-11-12 14:43:17 UTC 
hrm, should be closed