Bug 329347 – app-misc/when-1.1.20 version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Tim Harder 2010-07-21 23:15:26 UTC]

A new release is available. See the attached patch for minor ebuild updates.

[Comment 1 Tim Harder 2010-07-21 23:21:08 UTC]

Created attachment 239735 [details, diff]
Ebuild updates for when-1.1.20

Ebuild updates for when-1.1.20:
  * Use EAPI 2
  * Add dev-lang/perl to DEPEND (used for test phase) and RDEPEND
  * Use quotes for S
  * Use the src_prepare phase from EAPI 2 instead of src_unpack

Note that the tarball will have to be downloaded from [1], modified so its name is when-1.1.20.tar.gz instead of when.tar.gz, and uploaded to the Gentoo mirrors for the patch to work correctly.

[1] http://www.lightandmatter.com/when/when.tar.gz

[Comment 2 Samuli Suominen (RETIRED) 2010-07-22 00:30:15 UTC]

(In reply to comment #1)
> Created an attachment (id=239735) [details]

This is wrong:

+S="${WORKDIR}/when_dist"

Bash assignment doesn't need quoting. It's correct in tree.

[Comment 3 Tim Harder 2010-07-22 00:44:19 UTC]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=239735) [details] [details]
> 
> This is wrong:
> 
> +S="${WORKDIR}/when_dist"
> 
> Bash assignment doesn't need quoting. It's correct in tree.

I agree since there shouldn't be any spaces in the variable. For some reason, I remember reading official docs stating S should be quoted, but that was awhile ago. At some point it must have been advised or regularly practiced for aesthetic reasons since out of 8708 ebuilds that set S in the tree, 4543 use quotes and 4165 don't by my calculations.

Anyway, I'll update the patch and drop the quotes.

[Comment 4 Tim Harder 2010-07-22 00:55:01 UTC]

Created attachment 239747 [details, diff]
Ebuild updates for when-1.1.20

Changes for previous patch:
  * Don't quote S as requested

[Comment 5 Jeremy Olexa (darkside) (RETIRED) 2010-07-23 01:32:19 UTC]

-SRC_URI="mirror://gentoo/${P}.tar.gz"
+SRC_URI="http://gentoo.radhermit.com/distfiles/${P}.tar.gz"

Q: Why are you hosting this file?

[Comment 6 Tim Harder 2010-07-23 01:41:52 UTC]

(In reply to comment #5)
> -SRC_URI="mirror://gentoo/${P}.tar.gz"
> +SRC_URI="http://gentoo.radhermit.com/distfiles/${P}.tar.gz"
> 
> Q: Why are you hosting this file?

Oops, I did the first patch the right way and then forgot to change it back when I made the second patch. Basically, I'm hosting the file that way so the ebuild works for my overlay since the tarball isn't versioned correctly upstream as I mention in the initial comment, but the tarball only needs to be uploaded to the gentoo distfiles so it works with the standard SRC_URI.

I'll attach a new patch that fixes the issue.

[Comment 7 Tim Harder 2010-07-23 01:43:11 UTC]

Created attachment 239881 [details, diff]
Ebuild updates for when-1.1.20

Changes from previous patch:
  * Fix SRC_URI to point to gentoo distfiles location

[Comment 8 Jeremy Olexa (darkside) (RETIRED) 2010-07-23 02:46:04 UTC]

Ah. I took a different approach with "SRC_URI arrows" as they call it. Feel free to take a look :)

Thanks.

[Comment 9 Tim Harder 2010-07-23 03:33:32 UTC]

(In reply to comment #8)
> Ah. I took a different approach with "SRC_URI arrows" as they call it. Feel
> free to take a look :)

Nice. I actually considered doing that as well but I haven't run into it very often in the tree yet so I didn't know if it was meant for this case.