Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 329157 - xfce-extra/xfce4-power-manager-0.9.98 ignores policykit use-flag due to upstream errors
Summary: xfce-extra/xfce4-power-manager-0.9.98 ignores policykit use-flag due to upstr...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-20 20:10 UTC by Livid
Modified: 2010-08-06 21:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch (0.9.98-polkit.patch,930 bytes, patch)
2010-07-20 20:11 UTC, Livid
Details | Diff
Complimentary ebuild (xfce4-power-manager-0.9.98-r1.ebuild,1.81 KB, text/plain)
2010-07-20 20:12 UTC, Livid
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Livid 2010-07-20 20:10:21 UTC
It does not matter if policykit useflag is enabled or disabled, xfpm-0.9.98 builds with polkit support anyway, since configure ignores --disable-polkit flag
Proposed patches and complimentary ebuild attached. See also http://bugzilla.xfce.org/show_bug.cgi?id=6568

Reproducible: Always

Steps to Reproduce:
1. set USE-=policykit
2. emerge xfce4-power-manager
3. run xfce-power-manager --dump | head -n4 | tail -n1

Actual Results:  
With policykit support

Expected Results:  
Without policykit support

Since there are some policykit-related bugs in xfpm-0.9.98 (e.g. http://bugzilla.xfce.org/show_bug.cgi?id=6462), I suppose inability to turn it off results in some major loss of functionality.
Comment 1 Livid 2010-07-20 20:11:29 UTC
Created attachment 239595 [details, diff]
Proposed patch

Patch is very simplistic, but it works for me.
Comment 2 Livid 2010-07-20 20:12:20 UTC
Created attachment 239597 [details]
Complimentary ebuild

Applies patch and runs autoconf.
Comment 3 Wormo (RETIRED) gentoo-dev 2010-07-20 23:21:21 UTC
Simple is good, when you can get away with it. Thanks for submitting your fix -- assigning to xfce team
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2010-08-06 20:42:20 UTC
I'm not sure if xfce4-power-manager is useful without polkit, but here goes:

  06 Aug 2010; Samuli Suominen <ssuominen@gentoo.org>
  xfce4-power-manager-0.9.98.ebuild,
  +files/xfce4-power-manager-0.9.98-fix_polkit_switch.patch:
  Fix --disable-polkit configure switch wrt #329157 by "Livid". Remove postinst message because
  xfce-base/xfce-utils >= 4.6.2-r1 will start xfce4-session with ck-launch-session.
Comment 5 Livid 2010-08-06 21:38:40 UTC
It actually IS useful without polkit. It just fallbacks to dbus and whatnot.
Thank you.