Now that perl-5.12 is in the tree the version check logic in perl-cleaner is broken (that is on line 109 there). Reproducible: Always
Created attachment 239573 [details, diff] Simplistic fix This is the simplistic fix for this issue. Maybe we rather like to require version>=5.8 here instead of hardcoding.
Sorry, please elaborate on what you mean by "broken", Perl cleaner works fine for me on 5.12.1, so its not overly apparent what the problem is. You have proposed a fix, but its not obvious what that fix even does. Please do expand a little more =).
Hi, sorry for being so brief. I tried to reproduce this issue for a more detailed error message, but it is gone now that I successfully ran perl-cleaner. I remember h2ph complaining about missing includes (like stubs-64.h on my 32-bit system) just below that block where the patch took effect, so maybe the problem was not in perl-cleaner, but in one on the programs (h2ph?) it called. Sorry.
Yes, you see, the condition in the code you modified to "fix" this problem was intentional to produce an alternative path for 5.12 and above, because we don't want as many of the needless .ph files lying around if we really don't need them. ( as most things don't, and only a few obscure libraries use a few of them ) If you can *unfix* your copy of perl-cleaner and see if you can get it to make it repeat the problem, that would be great =). ( h2ph comes with perl, and its some pretty nasty code, upstream are trying to kill it off somehow, but its hard )
Benjamin, I am going to close it as invalid because "12" was not included for one reason afaik because of h2ph using deprecated goto; http://www.gossamer-threads.com/lists/perl/porters/250790 And also what Kent was referring to as he knows Perl pretty well ++ I really don't know the inner workings of Perl I am just helping wrangle some bugs. Please if this is wrong please reopen and thank you for taking the time to fill out the bug and provide the patch, I in no way want to discourage you in the future :)
Comment on attachment 239573 [details, diff] Simplistic fix Hi David, thank you for wrangling bugs, but I would like to add more info here. I am removing the patch so I doesn't get propagated and mark this as NEEDSINFO (from me). I will follow up.
Reopening for more info.
