Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 32906 - ipvsadm-1.21 ebuild inappropriately installs the ipvsadm binary in /etc/init.d
Summary: ipvsadm-1.21 ebuild inappropriately installs the ipvsadm binary in /etc/init.d
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Brian Jackson (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-06 13:58 UTC by Jacob Smullyan
Modified: 2003-12-07 07:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob Smullyan 2003-11-06 13:58:46 UTC
The summary just about says it.  It appears to be done very deliberately, but I
 can't think of a reason to install the binary in /etc/init.d.  I think those
two lines in the ebuild:

        exeinto /etc/init.d
        doexe ipvsadm

should just come out.

Reproducible: Always
Steps to Reproduce:
Comment 1 Brian Jackson (RETIRED) gentoo-dev 2003-11-09 07:29:56 UTC
sorry, that is mine ;)
Comment 2 Brian Jackson (RETIRED) gentoo-dev 2003-11-12 14:00:29 UTC
I think that was supposed to be ipvsadm.sh which is a startup script. I went ahead and wrote a Gentoo'ized startup script for ipvsadm. Give the mirrors a while to update and then give it a try. I havent' bumped it yet, I want to get somebody else to test it. So let me know if it works okay for you.
Comment 3 Jacob Smullyan 2003-11-14 12:30:41 UTC
You have a nasty typo in the stable ebuild now -- after

  exeinto /etc/init.d/

you have 

   newbin ${FILESDIR}/ipvsadm-init ipvsadm

which puts your runscript into  /bin/ipvsadm, masking the real ipvsadm in /sbin.  This needs fixin'!  If anyone has a script running that calls ipvsadm without the full path and reinstalls for some reason, they'll be unhappy.

Also, your init script, which you cloned from iptables, still refers to iptables where it means to say ipvsadm in an eerror message.

Comment 4 Brian Jackson (RETIRED) gentoo-dev 2003-11-14 12:58:26 UTC
good catch, it's supposed to be newexe, fixed that and the init script in cvs
Comment 5 Heinrich Wendel (RETIRED) gentoo-dev 2003-12-07 07:43:26 UTC
so we can close it ;)