Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 328653 - net-misc/mico: Binary file files/mico-2.3.13-winnt.patch.bz2 in gentoo-x86
Summary: net-misc/mico: Binary file files/mico-2.3.13-winnt.patch.bz2 in gentoo-x86
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High QA
Assignee: Michael Haubenwallner (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: binaries-in-git
  Show dependency tree
 
Reported: 2010-07-16 20:57 UTC by Samuli Suominen (RETIRED)
Modified: 2010-08-16 15:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2010-07-16 20:57:51 UTC
Move it to mirrors, binary files are not allowed in gentoo-x86.

ssuominen@unique ~/gentoo-x86/net-misc/mico $ file files/mico-2.3.13-winnt.patch.bz2 
files/mico-2.3.13-winnt.patch.bz2: bzip2 compressed data, block size = 900k
Comment 1 Michael Haubenwallner (RETIRED) gentoo-dev 2010-08-16 08:23:43 UTC
Hmm - has this policy been changed in the past?
While I'm aware of the 64kB limit, IIRC it is (was?) legal to compress larger patches.

I prefer to have patches in some VCS, not just tarballs. This would mean I'd have to create some mico-patches repository somewhere. While this shouldn't be a problem in genereal, it slightly increases patch maintenance work.
Given that this patch has an uncompressed size of ~65kB, I've splitted it up into 2 smaller ones.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-08-16 10:35:51 UTC
The size has always been 20k, not 64k, and given CVS is CVS it was never allowed to compress the patches.

We already have a gentoo/patches repository in CVS. Remember that the gentoo-x86 tree is sent down to the users with each rsync, big patches should *not* be there at all.
Comment 3 Michael Haubenwallner (RETIRED) gentoo-dev 2010-08-16 15:26:27 UTC
Ok, completely dropped FILESDIR.

(In reply to comment #2)
> The size has always been 20k, not 64k,

Dunno 20k being the 'soft limit', thx!

> We already have a gentoo/patches repository in CVS.

Wasn't aware of such a generic repo existing.
Actually, you mean gentoo/src/patchsets/ (have found this one making sense only)?
Eventually worth to add a note to devmanual?

Thank you!