Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 328517 - net-misc/asterisk ebuilds depends on environmental variables
Summary: net-misc/asterisk ebuilds depends on environmental variables
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-16 00:09 UTC by Jaco Kroon
Modified: 2010-07-19 15:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
asterisk-1.6.2.9-no-env-var-deps.ebuild.patch (asterisk-1.6.2.9-no-env-var-deps.ebuild.patch,1.58 KB, patch)
2010-07-16 00:11 UTC, Jaco Kroon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaco Kroon 2010-07-16 00:09:19 UTC
The asterisk ebuilds varies behavior based on whether ASTERISK_MODULES is set or not.  This cannot possibly be good in that an emerge -pv will not actually show you what is going to be merged.

Additionally googling around reveals that others also feel relatively strongly about this (http://blog.flameeyes.eu/2009/10/04/explaining-the-sudo-crapfest).  Whilst I do not feel quite that strongly about it it is something that should be removed in order to prevent confusion.  The apache2 ebuilds took a similar route in moving away from storing the module list in a file towards using an EXPAND_USE variable in the form of APACHE2_MODULES, if there is really a need for this ability then I would suggest going that route.

Additionally, as it stands emerge -N won't pick up if asterisk needs to be remerged or not.

One may forget to set the environmental variables next time you merge.

There is no way to check with what value of this variable the ebuild has been merged.

Difficult to support the ebuild ...

And so on ...

Reproducible: Always
Comment 1 Jaco Kroon 2010-07-16 00:11:52 UTC
Created attachment 238961 [details, diff]
asterisk-1.6.2.9-no-env-var-deps.ebuild.patch

This patch rips the environment variable dependencies out of the ebuild.  Compile tested.

Should apply cleanly to 1.6.1.20 and 1.6.2.8 as well.
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2010-07-19 15:38:26 UTC
I cut out more code from the ebuild that's no longer required.
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2010-07-19 15:48:12 UTC
+*asterisk-1.6.2.9-r1 (19 Jul 2010)
+
+  19 Jul 2010; <chainsaw@gentoo.org> +files/1.6.2/asterisk.initd,
+  +files/1.6.2/call_data.txt, +files/1.6.2/find_call_ids.sh,
+  +files/1.6.2/find_call_sip_trace.sh, +files/1.6.2/sip_calc_auth,
+  +asterisk-1.6.2.9-r1.ebuild:
+  Revision bump for enhancements by Jaco Kroon in bugs #300832, #305265 &
+  #328517. This improves the initscript and simplifies the ebuild.
+  Environmental variables for module overrides (which were a bad idea in the
+  first place) are no longer supported.