Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 328187 - media-video/mpeg-tools-1.5b-r4: keyword request with patch
Summary: media-video/mpeg-tools-1.5b-r4: keyword request with patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: AMD64 OS X
: High enhancement (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-13 23:39 UTC by Johan Hattne
Modified: 2011-12-15 19:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix malloc.h vs stdlib.h issue, to be applied from $WORKDIR (mpeg-tools-1.5b-malloc.patch,2.00 KB, patch)
2010-07-13 23:41 UTC, Johan Hattne
Details | Diff
Modified powerpc patch for darwin (mpeg-tools-1.5b-powerpc.patch,1.02 KB, patch)
2011-01-25 18:26 UTC, Johan Hattne
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Hattne 2010-07-13 23:39:58 UTC
media-video/mpeg-tools-1.5b-r4 likes to include malloc.h, where it probably should have included stdlib.h.  The attached patch addresses those issues.  Then, the ebuild compiles fines and passes all its test.  Could it please be keyworded ~x64-macos?

Reproducible: Always

Steps to Reproduce:
1. ACCEPT_KEYWORDS="~x86-linux" emerge mpeg-tools

Actual Results:  
x86_64-apple-darwin10-gcc -march=nocona -O2 -pipe -Iheaders -Wall -Wmissing-prototypes     -c -o huff.o huff.c
In file included from headers/all.h:83,
                 from postdct.c:116:
headers/libpnmrw.h:22:20: error: malloc.h: No such file or directory
In file included from headers/all.h:83,
                 from mfwddct.c:18:
headers/libpnmrw.h:22:20: error: malloc.h: No such file or directory
make: *** [postdct.o] Error 1


Expected Results:  
mpeg-tools merged
Comment 1 Johan Hattne 2010-07-13 23:41:36 UTC
Created attachment 238649 [details, diff]
Patch to fix malloc.h vs stdlib.h issue, to be applied from $WORKDIR
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2010-07-29 23:18:41 UTC
glibc installs malloc.h. can you followup with upstream on this issue and report back?
Comment 3 Fabian Groffen gentoo-dev 2010-07-30 07:26:00 UTC
using stdlib.h is the right approach
Comment 4 Johan Hattne 2010-07-30 20:39:52 UTC
(In reply to comment #2)
> glibc installs malloc.h. can you followup with upstream on this issue and
> report back?

I have no idea where upstream's gone.  The machine serving the homepage given in the ebuild is gone, and IT services at Stanford claim the package is unsupported (http://www.stanford.edu/service/pubsw/package/graphics/mpegencode.html).

Unsurprisingly, I completely agree with grobian's comment #3.
Comment 5 Johan Hattne 2011-01-25 18:26:18 UTC
Created attachment 260704 [details, diff]
Modified powerpc patch for darwin

And if--in addition to the previous patch--mpeg-tools-1.5b-powerpc.patch is modified to the attached, the thing tests fine on ~ppc-macos as well.  Could that keyword please be added as well?
Comment 6 Fabian Groffen gentoo-dev 2011-12-15 19:36:08 UTC
Ok, changes applied.  The malloc.h thing I solved with a sed instead.