Bug 327555 – media-video/avidemux-2.5.1_p5428: automagic dependency on media-sound/pulseaudio

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mike Gilbert 2010-07-09 04:53:21 UTC]

Avidemux automagically links with libpulse-simple.so from pulseaudio.

The ebuild passes "-DPULSEAUDIOSIMPLE=0" to the cmake build system when the pulseaudio use flag is disabled, but the relevant makefile is not set up to correctly process such a flag.

Reproducible: Always

Steps to Reproduce:
1. emerge media-sound/pulseaudio.
2. emerge media-video/avidemux with the pulseaudio use flag disabled.
Actual Results:  
Build process finds the installed pulseaudio libraries and builds the pulseAudioSimple device plugin, linking with libpulse-simple.so.

The pulseAudioSimple plugin is installed at /usr/lib/ADM_plugins/audioDevices/libADM_av_pulseAudioSimple.so.

Expected Results:  
Should ignore the libpulse-simple.so library and build without pulseaudio support.

libADM_av_pulseAudioSimple.so should not exist.

[Comment 1 Markos Chandras (RETIRED) 2010-07-10 17:37:04 UTC]

Could you reproduce it with the latest avidemux-2.5.3-r1?

[Comment 2 Mike Gilbert 2010-07-10 19:04:37 UTC]

Yes; same thing happens.

[Comment 3 Mike Gilbert 2010-07-10 19:06:22 UTC]

Created attachment 238235 [details, diff]
Fix admCheckAudioDeviceLibs.cmake

Here is a patch to fix the build system.

[Comment 4 Mike Gilbert 2010-07-10 19:10:40 UTC]

This also seems to be a problem in the latest upstream SVN rev:

http://www.avidemux.org/admWiki/doku.php?id=build:install_2.5#getting_the_source
svn://svn.berlios.de/avidemux/branches/avidemux_2.5_branch_gruntster

If the patch looks good to you, I can create a post in their forums; there doesn't seem to be a bug tracker.

[Comment 5 Markos Chandras (RETIRED) 2010-07-10 19:22:52 UTC]

Yes the patch looks good. I was about to ask you if this patch is on svn since I couldn't find it but you were faster than me :)

Please let upstream know about your patch. When you post to their forums please post the URL here so I can track it

Thanks

[Comment 6 Mike Gilbert 2010-07-10 19:54:04 UTC]

Upstream forum post:

http://avidemux.org/admForum/viewtopic.php?id=8035

[Comment 7 Markos Chandras (RETIRED) 2010-08-01 10:27:12 UTC]

Patch applied

Upstream looks kinda slow on that

Thanks for reporting


+*avidemux-2.5.3-r2 (01 Aug 2010)
+
+  01 Aug 2010; Markos Chandras <[e-mail]>
+  +avidemux-2.5.3-r2.ebuild, +files/avidemux-pulseaudiosimple.patch:
+  Apply patch to fix pulseaudio automagic dependency. Fixes bug #327555.
+  Thanks to Mike Gilbert <[e-mail]> for the patch
+

[Comment 8 Mike Gilbert 2010-08-04 02:04:29 UTC]

(In reply to comment #7)
> Upstream looks kinda slow on that
> 

FYI, this got merged upstream after I bumped the thread.

r6497 | mean | 2010-08-02 01:42:11 -0400 (Mon, 02 Aug 2010) | 1 line

[Pulse] automagic deps removal for pulse simple, patch by floppymaster