Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 327459 - sys-power/sispmctl-2.7 buffer overflow issue
Summary: sys-power/sispmctl-2.7 buffer overflow issue
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Wolfram Schlich (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2010-07-08 10:41 UTC by Fabian Köster
Modified: 2016-01-27 13:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Köster 2010-07-08 10:41:01 UTC
sispmctl-2.7 is running here fine on x86 and ARM for a long time.

Please stabilize it on x86, amd64 and ARM. 

Reproducible: Always
Comment 1 Fabian Köster 2010-07-08 21:41:10 UTC
Furthermore: No open bugs
Comment 2 Riccardo 2010-09-21 10:01:28 UTC
On 64bit system:
sispmctl -s
Gembird #0 is USB device 003.This device is a 4-socket SiS-PM.
Accessing Gembird #0 USB device 003
*** buffer overflow detected ***: sispmctl terminated
======= Backtrace: =========
/lib/libc.so.6(__fortify_fail+0x37)[0x7fb2dfa90197]
/lib/libc.so.6(+0xe4ff0)[0x7fb2dfa8dff0]
/lib/libc.so.6(+0xe4359)[0x7fb2dfa8d359]
/lib/libc.so.6(_IO_default_xsputn+0x85)[0x7fb2dfa1a095]
/lib/libc.so.6(_IO_vfprintf+0x63a)[0x7fb2df9eb45a]
/lib/libc.so.6(__vsprintf_chk+0x9d)[0x7fb2dfa8d3fd]
/lib/libc.so.6(__sprintf_chk+0x7f)[0x7fb2dfa8d33f]
sispmctl[0x401118]
sispmctl[0x401731]
sispmctl[0x401a34]
/lib/libc.so.6(__libc_start_main+0xfd)[0x7fb2df9c7bbd]
sispmctl[0x400c89]
======= Memory map: ========
00400000-00403000 r-xp 00000000 09:01 7195601                            /usr/bin/sispmctl
00602000-00603000 r--p 00002000 09:01 7195601                            /usr/bin/sispmctl
00603000-00604000 rw-p 00003000 09:01 7195601                            /usr/bin/sispmctl
021f3000-02214000 rw-p 00000000 00:00 0                                  [heap]
7fb2df792000-7fb2df7a7000 r-xp 00000000 09:01 6393676                    /lib64/libgcc_s.so.1
7fb2df7a7000-7fb2df9a7000 ---p 00015000 09:01 6393676                    /lib64/libgcc_s.so.1
7fb2df9a7000-7fb2df9a8000 r--p 00015000 09:01 6393676                    /lib64/libgcc_s.so.1
7fb2df9a8000-7fb2df9a9000 rw-p 00016000 09:01 6393676                    /lib64/libgcc_s.so.1
7fb2df9a9000-7fb2dfaf9000 r-xp 00000000 09:01 6341250                    /lib64/libc-2.11.2.so
7fb2dfaf9000-7fb2dfcf8000 ---p 00150000 09:01 6341250                    /lib64/libc-2.11.2.so
7fb2dfcf8000-7fb2dfcfc000 r--p 0014f000 09:01 6341250                    /lib64/libc-2.11.2.so
7fb2dfcfc000-7fb2dfcfd000 rw-p 00153000 09:01 6341250                    /lib64/libc-2.11.2.so
7fb2dfcfd000-7fb2dfd02000 rw-p 00000000 00:00 0
7fb2dfd02000-7fb2dfd09000 r-xp 00000000 09:01 6341199                    /lib64/libusb-0.1.so.4.4.4
7fb2dfd09000-7fb2dff08000 ---p 00007000 09:01 6341199                    /lib64/libusb-0.1.so.4.4.4
7fb2dff08000-7fb2dff09000 r--p 00006000 09:01 6341199                    /lib64/libusb-0.1.so.4.4.4
7fb2dff09000-7fb2dff0b000 rw-p 00007000 09:01 6341199                    /lib64/libusb-0.1.so.4.4.4
7fb2dff0b000-7fb2dff29000 r-xp 00000000 09:01 6341249                    /lib64/ld-2.11.2.so
7fb2e0103000-7fb2e0106000 rw-p 00000000 00:00 0
7fb2e0126000-7fb2e0128000 rw-p 00000000 00:00 0
7fb2e0128000-7fb2e0129000 r--p 0001d000 09:01 6341249                    /lib64/ld-2.11.2.so
7fb2e0129000-7fb2e012a000 rw-p 0001e000 09:01 6341249                    /lib64/ld-2.11.2.so
7fb2e012a000-7fb2e012b000 rw-p 00000000 00:00 0
7fff79017000-7fff79038000 rw-p 00000000 00:00 0                          [stack]
7fff791c1000-7fff791c2000 r-xp 00000000 00:00 0                          [vdso]
ffffffffff600000-ffffffffff601000 r-xp 00000000 00:00 0                  [vsyscall]

I found this patch on google:
http://sisyphus.ru/ru/srpm/Sisyphus/sispmctl/patches/1
It's possible to include in portage?

Best regards
Comment 3 Wolfram Schlich (RETIRED) gentoo-dev 2013-03-03 17:30:02 UTC
So does the patch fix the problem for you, have you tried it?
Comment 4 Dmitri Bogomolov 2013-05-18 18:07:32 UTC
(In reply to comment #3)
> So does the patch fix the problem for you, have you tried it?

This patch fixed the problem for me.
Comment 5 Wolfram Schlich (RETIRED) gentoo-dev 2014-03-30 13:55:06 UTC
Riccardo, Dmitri: I just committed =sys-power/sispmctl-3.1. ALT Linux does not apply the buffer patch for 2.7 to their 3.1 package, so I had a look at the sispm_ctl.c file that it initially patched: the first section of the patch is included in 3.1 (char buffer -> unsigned char buffer), but the 2nd is not. Can you please check if that change is sufficient for it to run on your systems?
Comment 6 Wolfram Schlich (RETIRED) gentoo-dev 2016-01-27 13:44:54 UTC
Removed 2.7 from portage. Problem is fixed in 3.1.