Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 327369 - media-libs/a52dec-0.7.4-r6 - Test failed on hardened profile
Summary: media-libs/a52dec-0.7.4-r6 - Test failed on hardened profile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 18:44 UTC by Martin Rejman
Modified: 2010-07-26 01:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed solution based on the closed bug mentioned before. (a52dec.patch,504 bytes, patch)
2010-07-07 18:46 UTC, Martin Rejman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Rejman 2010-07-07 18:44:33 UTC
TEST failed on a x86 with hardened profile.

Solution should be similar to http://bugs.gentoo.org/show_bug.cgi?format=multiple&id=130831 

I prepared a patch in the same manner, the test gives then:

make  check-TESTS
make[2]: Entering directory `/var/tmp/portage/media-libs/a52dec-0.7.4-r6/work/a52dec-0.7.4/test'
SKIP: regression
SKIP: compile
PASS: globals
======================
1 test passed
(2 tests were not run)
======================




Reproducible: Always

Steps to Reproduce:
1. FEATURES=test emerge media-libs/a52dec
2.
3.

Actual Results:  
Test fails

Expected Results:  
Test passes
Comment 1 Martin Rejman 2010-07-07 18:46:33 UTC
Created attachment 237931 [details, diff]
Proposed solution based on the closed bug mentioned before.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2010-07-07 18:52:29 UTC
right, the "solution" for bug 143058 (my fault, btw) is also wrong, the filter-flags is too late in the ebuild... should be in src_configure.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2010-07-25 17:58:25 UTC
(In reply to comment #2)
> right, the "solution" for bug 143058 (my fault, btw) is also wrong, the
> filter-flags is too late in the ebuild... should be in src_configure.
> 

+  25 Jul 2010; Samuli Suominen <ssuominen@gentoo.org>
+  a52dec-0.7.4-r6.ebuild:
+  Move filter-flags for -fPIE before econf so it has some effect wrt
+  #327369.

Can you verify it solves this issue as well?  I'm not really fan of the attached patch because it adds extra pax-utils build dependency.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2010-07-25 18:21:15 UTC
Sorry, misread the readelf as scanelf... the patch looks good to go, if it works, the filter-flags -fPIE can be dropped from the ebuild entirely -- most likely
I can't really test any of this myself, no hardened system
Comment 5 Magnus Granberg gentoo-dev 2010-07-25 23:27:10 UTC
make  check-TESTS
make[2]: Entering directory `/var/tmp/portage/media-libs/a52dec-0.7.4-r6/work/a52dec-0.7.4/test'
SKIP: regression
SKIP: compile
PASS: globals
======================
1 test passed
(2 tests were not run)
======================
Run fine with that patch.
Portage 2.1.8.3 (hardened/linux/x86/10.0, gcc-4.4.4, glibc-2.11.2-r0, 2.6.32-hardened-r4 x86_64)
=================================================================
System uname: Linux-2.6.32-hardened-r4-x86_64-Intel-R-_Xeon-R-_CPU_E5420_@_2.50GHz-with-gentoo-2.0.1
Timestamp of tree: Sun, 25 Jul 2010 21:45:01 +0000
app-shells/bash:     4.1_p7
dev-lang/python:     2.5.2-r7, 2.6.5-r2, 3.1.2-r3
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.1-r1
sys-apps/sandbox:    2.2
sys-devel/autoconf:  2.65-r1
sys-devel/automake:  1.10.2, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.3.2-r8, 4.4.4-r1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
virtual/os-headers:  2.6.34
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="i686-pc-linux-gnu"
Comment 6 Magnus Granberg gentoo-dev 2010-07-26 01:23:12 UTC
commited to the tree