Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 327231 - net-irc/kvirc should use REQUIRED_USE
Summary: net-irc/kvirc should use REQUIRED_USE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Proxy Maintainers
URL: http://devmanual.gentoo.org/general-c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-06 23:17 UTC by Samuli Suominen (RETIRED)
Modified: 2012-02-04 09:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2010-07-06 23:17:18 UTC
The ebuild shouldn't be dying in pkg_setup(), instead it should enable the necessary flags by itself.

http://devmanual.gentoo.org/general-concepts/use-flags/index.html:

"Occasionally, ebuilds will have conflicting USE flags for functionality. Checking for them and returning an error is not a viable solution. Instead, you must pick one of the USE flags in conflict to favour."

if use audiofile && ! use oss; then
  die "USE=\"audiofile\" requires USE=\"oss\""
fi

if use theora && ! use dcc_video; then
  die "USE=\"theora\" requires USE=\"dcc_video\""
fi
Comment 1 Markos Chandras (RETIRED) gentoo-dev 2012-02-03 22:45:29 UTC
Index: kvirc-4.2_pre5816.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/net-irc/kvirc/kvirc-4.2_pre5816.ebuild,v
retrieving revision 1.3
diff -u -b -B -u -r1.3 kvirc-4.2_pre5816.ebuild
--- kvirc-4.2_pre5816.ebuild	19 Jun 2011 13:51:54 -0000	1.3
+++ kvirc-4.2_pre5816.ebuild	3 Feb 2012 22:44:47 -0000
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/net-irc/kvirc/kvirc-4.2_pre5816.ebuild,v 1.3 2011/06/19 13:51:54 maekke Exp $
 
-EAPI="3"
+EAPI="4"
 PYTHON_DEPEND="python? 2"
 
 inherit cmake-utils multilib python
@@ -44,15 +44,9 @@
 
 DOCS="ChangeLog doc/FAQ"
 
-pkg_setup() {
-	if use audiofile && ! use oss; then
-		die "USE=\"audiofile\" requires USE=\"oss\""
-	fi
-
-	if use theora && ! use dcc_video; then
-		die "USE=\"theora\" requires USE=\"dcc_video\""
-	fi
+REQUIRED_USE="audiofile? ( oss ) theora? ( dcc_video )"
 
+pkg_setup() {
 	if use python; then
 		python_set_active_version 2
 		python_pkg_setup

Proposed patch. ETA 2 days
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2012-02-04 09:57:02 UTC
Fixed