Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 327063 - git.eclass: doesnt stop properly when checkout failed
Summary: git.eclass: doesnt stop properly when checkout failed
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal
Assignee: Tomáš Chvátal (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-05 22:27 UTC by Enrico 'nekrad' Weigelt
Modified: 2011-04-20 21:47 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
fix for git.eclass (0001-eclass-git.eclass-aborting-when-checkout-failed.patch,698 bytes, patch)
2010-07-05 22:28 UTC, Enrico 'nekrad' Weigelt 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrico 'nekrad' Weigelt 2010-07-05 22:27:36 UTC 
When a checkout fails, it doesn't stop properly, but tries to continue, so it's  hard to find out what really went wrong.

(just a little "|| die" would do the trick).

Reproducible: Always
Comment 1 Enrico 'nekrad' Weigelt 2010-07-05 22:28:45 UTC 
Created attachment 237649 [details, diff]
fix for git.eclass
Comment 2 katabami 2011-01-25 06:23:54 UTC 
+1
This one-liner fix is so important to for development use of Gentoo, though may not be so for the official portage tree.
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2011-04-20 21:47:33 UTC 
git.eclass is obsoleted by git-2 eclass.
It is more sanely separated and has dies on all proper places :)