Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 326855 - app-text/evince should depend on either gnome-icon-theme or hicolor-icon-theme
Summary: app-text/evince should depend on either gnome-icon-theme or hicolor-icon-theme
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2010-07-04 11:09 UTC by LB
Modified: 2010-09-15 18:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch configure.ac to disable compile time dependency on gnome-icon-theme (evince-hicolor-icon-theme.patch,646 bytes, patch)
2010-07-04 11:10 UTC, LB
Details | Diff
patch 2.30.3 ebuild to depend on either gnome-icon-theme or hicolor-icon-theme (evince-theme.patch,727 bytes, patch)
2010-07-04 11:11 UTC, LB
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description LB 2010-07-04 11:09:08 UTC
Evince should be able to depend on either gnome-icon-theme or hicolor-icon-theme. Comments in configure.ac state that evince developers put a hard compile time dependency on gnome-icon-theme because there is no way to check for presence of hicolor-icon-theme (no pkgconfig file). Since gentoo has it's own dependency checking, it can allow dependency on either of the two themes.
This would allow non-GNOME users to run evince with fewer dependencies.

Reproducible: Always

Steps to Reproduce:
1. emerge evince


Actual Results:  
gnome-icon-theme is installed

Expected Results:  
Should be able to use evince with hicolor-icon-theme
Comment 1 LB 2010-07-04 11:10:22 UTC
Created attachment 237433 [details, diff]
patch configure.ac to disable compile time dependency on gnome-icon-theme
Comment 2 LB 2010-07-04 11:11:09 UTC
Created attachment 237435 [details, diff]
patch 2.30.3 ebuild to depend on either gnome-icon-theme or hicolor-icon-theme
Comment 3 Pacho Ramos gentoo-dev 2010-07-04 16:33:18 UTC
Does evince really show all icons without gnome-icon-theme? Also, x11-themes/gnome-icon-theme doesn't pull so many extra dependencies... :-/
Comment 4 LB 2010-07-05 18:51:53 UTC
I've been using evince with hicolor-icon-theme and haven't noticed any missing or broken icons on my system. As for gnome-icon-theme, emerging it here pulls 6 additional packages. They don't take a massive amount of space, but with this many I'd certainly prefer to avoid dependency creep.
Comment 5 Andrew Brouwers 2010-07-11 23:48:16 UTC
I do this tweak locally too (but using simply sed in my ebuild).  The configure script explains that it can even depend on either one, so I think it's mostly harmless.  Evince is a great PDF viewer, and since they've removed many of the gnome requirements, it's nice for light-weight environments such as xfce too.
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2010-09-15 18:47:26 UTC
+  15 Sep 2010; Gilles Dartiguelongue <eva@gentoo.org> evince-2.30.3.ebuild:
+  Make hicolor-icon-theme an alternative to gnome-icon-theme, bug #326855.
+  Drop libtool-1 compat.

Fixed. Thanks for reporting.