Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 326823 - games-fps/quake4-data-1.0.2147.12 does not allow CDROM paths containing spaces
Summary: games-fps/quake4-data-1.0.2147.12 does not allow CDROM paths containing spaces
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-04 05:26 UTC by Jared B.
Modified: 2010-07-14 19:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
quake4-data/quake4-data-1.0.2147.12.ebuild (quake4-data-1.0.2147.12.ebuild,1.64 KB, text/plain)
2010-07-04 05:27 UTC, Jared B.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jared B. 2010-07-04 05:26:47 UTC
Very simply: quake4-data ebuild does not quote $CDROM_ROOT, thus installation will fail if the path has any spaces.

Attached ebuild properly quotes the variable to fix this problem, which is inline with other ebuilds providing similar functionality (doom3-data, etc.).

Reproducible: Always

Steps to Reproduce:
Comment 1 Jared B. 2010-07-04 05:27:27 UTC
Created attachment 237415 [details]
quake4-data/quake4-data-1.0.2147.12.ebuild
Comment 2 Michael Weber (RETIRED) gentoo-dev 2010-07-04 16:38:56 UTC
for the record, please submit diffs to the current tree ebuilds, but thanks!

io /tmp # diff -ru /usr/portage/games-fps/quake4-data/quake4-data-1.0.2147.12.ebuild test 
--- /usr/portage/games-fps/quake4-data/quake4-data-1.0.2147.12.ebuild   2008-09-26 21:05:58.000000000 +0200
+++ test        2010-07-04 18:37:24.000000000 +0200
@@ -33,20 +33,20 @@
                Setup/Data/q4base/pak007.pk4
        insinto "${dir}"/q4base
        einfo "Copying files from Disk 1..."
-       doins ${CDROM_ROOT}/Setup/Data/q4base/pak01{0,1,2}.pk4 \
-               ${CDROM_ROOT}/Setup/Data/q4base/zpak*.pk4 \
+       doins "${CDROM_ROOT}"/Setup/Data/q4base/pak01{0,1,2}.pk4 \
+               "${CDROM_ROOT}"/Setup/Data/q4base/zpak*.pk4 \
                || die "copying pak010->pak012 and zpack*"
        cdrom_load_next_cd
        einfo "Copying files from Disk 2..."
-       doins ${CDROM_ROOT}/Setup/Data/q4base/pak00{1,2,3}.pk4 \
+       doins "${CDROM_ROOT}"/Setup/Data/q4base/pak00{1,2,3}.pk4 \
                || die "copying pak001->pak003"
        cdrom_load_next_cd
        einfo "Copying files from Disk 3..."
-       doins ${CDROM_ROOT}/Setup/Data/q4base/pak00{4,5,6}.pk4 \
+       doins "${CDROM_ROOT}"/Setup/Data/q4base/pak00{4,5,6}.pk4 \
                || die "copying pak004->pak006"
        cdrom_load_next_cd
        einfo "Copying files from Disk 4..."
-       doins ${CDROM_ROOT}/Setup/Data/q4base/pak00{7,8,9}.pk4 \
+       doins "${CDROM_ROOT}"/Setup/Data/q4base/pak00{7,8,9}.pk4 \
                || die "copying pak007->pak009"
 
        find ${Ddir} -exec touch '{}' \;
Comment 3 Jared B. 2010-07-04 18:58:39 UTC
Sure, I can do that going forward.  You're the first person I've seen request a diff; didn't realize they were preferred.
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2010-07-14 19:11:10 UTC
in portage.  thanks for the bug report and patch.