Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 325973 - sys-boot/grub-1.98: grub-mkconfig(/etc/grub.d/10_linux) ignores builtin initrds
Summary: sys-boot/grub-1.98: grub-mkconfig(/etc/grub.d/10_linux) ignores builtin initrds
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo's Team for Core System packages
URL: https://savannah.gnu.org/bugs/?30364
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-28 12:22 UTC by Dennis Schridde
Modified: 2010-07-06 12:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2010-06-28 12:22:50 UTC
When CONFIG_INITRAMFS_SOURCE is set, no seperate initrd is necessary. grub-mkconfig from sys-boot/grub-1.98 (specifically /etc/grub.d/10_linux) ignores this and assumes:
"""
# "UUID=" magic is parsed by initrds.  Since there's no initrd, it can't work here
"""

I propose following fix:
--- /etc/grub.d/10_linux.orig   2010-06-28 14:22:06.080669780 +0200
+++ /etc/grub.d/10_linux        2010-06-28 14:21:24.177670182 +0200
@@ -128,7 +128,7 @@
   done
   if test -n "${initrd}" ; then
     echo "Found initrd image: ${dirname}/${initrd}" >&2
-  else
+  elif ! grep "CONFIG_INITRAMFS_SOURCE=" /boot/config-${version} 2> /dev/null ; then
     # "UUID=" magic is parsed by initrds.  Since there's no initrd, it can't work here.
     linux_root_device_thisversion=${GRUB_DEVICE}

Reproducible: Always
Comment 1 SpanKY gentoo-dev 2010-07-06 00:17:10 UTC
propose it upstream please
Comment 2 Dennis Schridde 2010-07-06 06:25:45 UTC
I created an upstream bug: https://savannah.gnu.org/bugs/?30364
Comment 3 SpanKY gentoo-dev 2010-07-06 12:45:37 UTC
thanks !  once they add the patch, feel free to post a link to the repo and i'll suck it back in.