Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 325323 - zfs-fuse should install default zfsrc-file
Summary: zfs-fuse should install default zfsrc-file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-24 10:51 UTC by Stefan G. Weichinger
Modified: 2010-06-25 06:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
default zfsrc from contrib-tree (zfsrc,2.41 KB, text/plain)
2010-06-24 10:52 UTC, Stefan G. Weichinger
Details
patch for ebuild zfs-fuse-0.6.9-r1.ebuild (patch,418 bytes, patch)
2010-06-24 10:54 UTC, Stefan G. Weichinger
Details | Diff
corrected patch (patch,432 bytes, patch)
2010-06-24 11:09 UTC, Stefan G. Weichinger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan G. Weichinger 2010-06-24 10:51:26 UTC
zfs-fuse-developer Seth Heeren suggested that our ebuild should install the default zfsrc from the contrib-tree on zfs-fuse.net

Reproducible: Always

Actual Results:  
no zfsrc

Expected Results:  
default zfsrc in /etc/zfs
Comment 1 Stefan G. Weichinger 2010-06-24 10:52:12 UTC
Created attachment 236377 [details]
default zfsrc from contrib-tree
Comment 2 Stefan G. Weichinger 2010-06-24 10:54:04 UTC
Created attachment 236379 [details, diff]
patch for ebuild zfs-fuse-0.6.9-r1.ebuild

inserts files/zfsrc into /etc/zfs
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2010-06-24 10:57:46 UTC
Comment on attachment 236377 [details]
default zfsrc from contrib-tree

Why put it in files/ directory when it's already included in the tarball and can be installed from there?
Comment 4 Stefan G. Weichinger 2010-06-24 11:09:09 UTC
Created attachment 236383 [details, diff]
corrected patch

You are absolutely right. Suggestion attached.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2010-06-24 11:10:42 UTC
(In reply to comment #4)
> Created an attachment (id=236383) [details]
> corrected patch
> 
> You are absolutely right. Suggestion attached.
> 

${WORKDIR]/${P} is same as default ${S}, and even ${S} is unnecessary when you can do:

doins ../contrib/zfsrc

just saying, no need for more attachements :)
Comment 6 Stefan G. Weichinger 2010-06-24 11:15:21 UTC
(In reply to comment #5)
> ${WORKDIR]/${P} is same as default ${S}, and even ${S} is unnecessary when you
> can do:
> 
> doins ../contrib/zfsrc
> 
> just saying, no need for more attachements :)

I am learning and learning ... ;-)
Thanks ...
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2010-06-24 11:18:35 UTC
fixed, without revision bump (considering this minor issue)

+  24 Jun 2010; Samuli Suominen <ssuominen@gentoo.org>
+  zfs-fuse-0.6.9-r1.ebuild:
+  Install default /etc/zfsrc wrt #325323 by Stefan G. Weichinger.
Comment 8 Stefan G. Weichinger 2010-06-24 11:23:00 UTC
(In reply to comment #7)
> fixed, without revision bump (considering this minor issue)
> 
> +  24 Jun 2010; Samuli Suominen <ssuominen@gentoo.org>
> +  zfs-fuse-0.6.9-r1.ebuild:
> +  Install default /etc/zfsrc wrt #325323 by Stefan G. Weichinger.

Will portage notify the user if he has a pre-existing and edited version of that file?
In my tests it does not tell me to run "dispatch-conf" or similar.