324567 – sys-fs/lvm2-2.02.67-r2: /etc/init.d/lvm-monitoring fails due to missing ret=0

Bug 324567 - sys-fs/lvm2-2.02.67-r2: /etc/init.d/lvm-monitoring fails due to missing ret=0

Summary: sys-fs/lvm2-2.02.67-r2: /etc/init.d/lvm-monitoring fails due to missing ret=0

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	Robin Johnson

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	324485
	Show dependency tree

Reported:	2010-06-18 08:55 UTC by Xake
Modified:	2010-06-18 17:11 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Xake 2010-06-18 08:55:45 UTC

Currently the lvm-monitoring script always fails due to a missing ret=0 statement resulting in the script always failing. This also leads to openrc running the script twice. During runlevel boot, and then retry during runlevel default.

Please apply the following patch:

--- /var/portage/sys-fs/lvm2/files/lvm-monitoring.initd-2.02.67-r2	2010-06-15 00:26:52.000000000 +0200
+++ /etc/init.d/lvm-monitoring	2010-06-18 10:38:59.339739342 +0200
@@ -16,6 +16,7 @@
 VGS=/sbin/vgs
 
 start() {
+	ret=0
 	# TODO do we want to separate out already active groups only?
 	VGSLIST=`$VGS --noheadings -o name 2> /dev/null`
 	for vg in $VGSLIST

Comment 1 Robin Johnson archtester

2010-06-18 17:11:58 UTC

InCVS.