Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 324093 - net-analyzer/rrdtool now uses libdbi but ebuild doesn't include a dbi USE flag
Summary: net-analyzer/rrdtool now uses libdbi but ebuild doesn't include a dbi USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-15 10:39 UTC by Chris Fletcher
Modified: 2012-06-02 14:14 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
add dbi USE flag (rrdtool-libdbi-patch,1.00 KB, patch)
2010-06-15 10:47 UTC, Chris Fletcher
Details | Diff
patch to add 'dbi' USE flag (rrdtool-1.4.3-libdbi-patch,1.12 KB, patch)
2010-10-18 20:40 UTC, Chris Fletcher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Fletcher 2010-06-15 10:39:36 UTC
The rrdtool-1.4.3 configure script will look for and use libdbi. The ebuild doesn't handle this so you can't specify a dbi USE flag to if you need it as a dependancy.

My simple patch that added '$(use_enable dbi libdbi) ' to the ebuild doesn't work because the configure script doesn't handle '--enable-libdbi', it seems to treat it as --disable-libdbi. Sigh.

Looks like we need a patch to the configure.ac so it works with the standard use_enable. I'm afraid I can't do that at the moment. Can someone who knows M4/configure do the patch.



Reproducible: Always

Steps to Reproduce:
1. build rrdtool without libdbi installed - not linked in (ldd /usr/bin/rrdtool)
2. build rrdtool with libdbi installed - it is linked in
Comment 1 Chris Fletcher 2010-06-15 10:47:52 UTC
Created attachment 235387 [details, diff]
add dbi USE flag

Simple patch to add dbi FLAG and use_enable - but the configure.ac script doesn't support --enable-libdbi so that needs patching too - which I haven't done.
Comment 2 Michael Weber (RETIRED) gentoo-dev 2010-06-15 11:03:11 UTC
You just need a "--disable-libdbi" in case you don't want to build against. And it does build against without further parameter?

$(use dbi || echo "--disable-libdbi") might be your man ;-)
Comment 3 Chris Fletcher 2010-10-18 20:40:22 UTC
Created attachment 251173 [details, diff]
patch to add 'dbi' USE flag

Included Michael's suggestion. Thanks.

made 'dbi' USE flag the default so as not to break those using it who upgrade without adding the flag. Those who don't use it and don't want it are more likely to notice the new packages being installed and can remove the flag.
Comment 4 Maxim Koltsov (RETIRED) gentoo-dev 2012-06-02 14:14:28 UTC
Fixed in 1.4.7.