Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 324089 - media-sound/radiotray-0.6: radio station deletion dialog does not close when you select "No"
Summary: media-sound/radiotray-0.6: radio station deletion dialog does not close when ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Markos Chandras (RETIRED)
URL: https://sourceforge.net/apps/trac/rad...
Whiteboard:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2010-06-15 10:33 UTC by Dean Matzkov
Modified: 2010-07-19 15:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix radio station deletion dialog bug (radiotray-0.6-dialogfix.patch,566 bytes, patch)
2010-06-15 12:05 UTC, Dean Matzkov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Matzkov 2010-06-15 10:33:10 UTC
Steps to reproduce:

1) Start-up radiotray and right-click its tray icon
2) Go to "Configure radios..."
3) Select a station, then click "Remove"
4) Click the "No" button in the dialog box

The dialog box stays open, and then any subsequent clicks on the "No" or "Yes" buttons do nothing. The only way to close it is by clicking the close button at the top-right of the dialog. However, if you click on "Yes" the first time, it performs as-expected.

The source of this bug is found in "${S}/src/BookmarkConfiguration.py", and is caused by the confirmation dialog only closing when it hits a certain condition (if the user clicked on "Yes"), which is around line 173.


Now, I would've proposed a patch for this, but I'm not very familiar with the Gentoo/Portage development process. And since this is also a rather trivial fix, I thought it was appropriate to report this here, instead of only filing the bug upstream.
Comment 1 Michael Weber (RETIRED) gentoo-dev 2010-06-15 10:53:22 UTC
Please file an upstream patch too and put a link to it in the URL field. Thanks
Comment 2 Michael Weber (RETIRED) gentoo-dev 2010-06-15 10:54:48 UTC
Nice, i cannot add the upstream maintainers to the CC field ;-)
carlosmribeiro1@gmail.com
ogmaciel@gnome.org
Comment 3 Dean Matzkov 2010-06-15 12:05:37 UTC
Created attachment 235405 [details, diff]
Patch to fix radio station deletion dialog bug
Comment 4 Dean Matzkov 2010-06-15 12:09:14 UTC
Just submitted a patch, and will also submit the same bug report & patch upstream.
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2010-06-17 11:21:58 UTC
I have contacted upstream in the past and they seem very cooperative. However I would suggest to directly send them your patch via email instead of the bug tracker 

This bug will remain open until the patch is officially accepted by upstream
Comment 6 Dean Matzkov 2010-07-19 15:36:18 UTC
Upstream has fixed the bug now, so we can mark this as fixed too.