Bug 323335 – gst-plugins-base.eclass & gst-plugins10.eclass cleanup/eapi aware review request

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Peter Volkov (RETIRED) 2010-06-09 14:43:03 UTC]

Hi guys. gst-plugins-base.eclass & gst-plugins10.eclass currently need some cleanup (qoutations, || die) and are EAPI unaware. Following patches fix this issues. Please, review and apply (or give me Ok to apply).

[Comment 1 Peter Volkov (RETIRED) 2010-06-09 14:44:30 UTC]

Created attachment 234719 [details, diff]
gst-plugins-base.eclass.patch

[Comment 2 Peter Volkov (RETIRED) 2010-06-09 14:45:06 UTC]

Created attachment 234721 [details, diff]
gst-plugins10.eclass.patch

[Comment 3 Gilles Dartiguelongue (RETIRED) 2010-06-09 14:59:21 UTC]

gstreamer herd is probably more indicated for this.

[Comment 4 Jeremy Olexa (darkside) (RETIRED) 2010-06-09 17:42:34 UTC]

Instead of: [[ -z ${ED} ]] && local ED=${D}

one might use:

has "${EAPI:-0}" 0 1 2 && use !prefix && ED="${D}"

[Comment 5 Peter Volkov (RETIRED) 2010-06-10 07:02:24 UTC]

Yup, but what benefit we gain from such modification? Code I've used was taken from toolchain.eclass (and is similar in other eclasses too).

[Comment 6 Gilles Dartiguelongue (RETIRED) 2012-11-22 11:03:34 UTC]

New eclasses are being reviewed on gentoo-dev ml. Please check there.

[Comment 7 Gilles Dartiguelongue (RETIRED) 2012-12-02 19:15:46 UTC]

The new eclasses have been commited. If you have problems with it, feel free to 
open a new report.