Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 323105 - <sys-process/acct-6.5.4-r2: Reported information is broken
Summary: <sys-process/acct-6.5.4-r2: Reported information is broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://bugs.debian.org/cgi-bin/bugrep...
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2010-06-07 18:03 UTC by Robert Trace
Modified: 2010-12-05 17:44 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Undo RedHat's broken patch to sa.c and restore functionality. (acct-6.5.4-backout-redhat-screwup.patch,1.84 KB, patch)
2010-06-07 18:05 UTC, Robert Trace
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Trace 2010-06-07 18:03:35 UTC
Upgrading from acct-6.5.1 to 6.5.4 renders all reported information useless.  Specifically, it went from this:

   15274     830.76re       1.49cp         0avio      3310k
      15     129.96re       0.67cp         0avio     17217k   ***other*
       4       2.17re       0.27cp         0avio     36064k   emerge
       5     108.50re       0.19cp         0avio     10597k   vim
     534       0.33re       0.17cp         0avio      6152k   cc1
      70       0.04re       0.02cp         0avio      8034k   filter-bash-env
     856       0.60re       0.02cp         0avio      2972k   sh
       3       0.49re       0.02cp         0avio      4690k   configure

to:

   15212        nanre        nancp       nanavio      3313k
    2445        nanre        nancp       nanavio      4679k   configure*
    1696        nanre        nancp       nanavio      4182k   sh*
    1350        nanre        nancp       nanavio      2752k   sed
    1324        nanre        nancp       nanavio      1653k   rm
    1211        nanre        nancp       nanavio      1704k   cat
     851        nanre        nancp       nanavio      2973k   sh
     585        nanre        nancp       nanavio      1712k   gcc


Notice all of the "NAN" values?

This is the result of a very bad patch from RedHat, at least part of which can be found in upstream's CVS (http://cvs.savannah.gnu.org/viewvc/acct/sa.c?root=acct&r1=1.28&r2=1.29).

Backing out this revision will restore functionality.


Reproducible: Always

Steps to Reproduce:
1. Upgrade to acct-6.5.4
2. /etc/init.d/acct report
3. Notice useless NAN'd data.

Actual Results:  
Useless data reported (improperly calculated statistics because of bad math).

Expected Results:  
Good math.  (No division by zero. :-)
Comment 1 Robert Trace 2010-06-07 18:05:08 UTC
Created attachment 234451 [details, diff]
Undo RedHat's broken patch to sa.c and restore functionality.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2010-11-05 16:22:29 UTC
-r2 fixes a major regression since 6.5.1, so I think it's important to get rid of the buggy -r0 as quickly as possible.

Arch teams, please test and mark stable:
=sys-process/acct-6.5.4-r2
Target KEYWORDS="alpha amd64 hppa ppc x86"
Comment 3 Markos Chandras (RETIRED) gentoo-dev 2010-11-06 12:40:33 UTC
amd64 done
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2010-11-08 21:12:12 UTC
Stable for HPPA PPC.
Comment 5 Christian Faulhammer (RETIRED) gentoo-dev 2010-11-10 12:12:21 UTC
x86 stable
Comment 6 Raúl Porcel (RETIRED) gentoo-dev 2010-12-05 17:44:55 UTC
alpha stable, closing