Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 322749 - G.723 broken in asterisk-1.6.2.7
Summary: G.723 broken in asterisk-1.6.2.7
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: High normal
Assignee: voip herd (OBSOLETE)
URL: http://groups.google.com/group/asteri...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-04 12:31 UTC by kfm
Modified: 2011-09-01 14:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Arkadi's format_g723.c patch (format_g723.diff,4.56 KB, patch)
2010-06-04 12:33 UTC, kfm
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kfm 2010-06-04 12:31:39 UTC
I noticed a thread on the asterisk-g729 mailing list where a user complained of issues using Arkadi Shishlov's G.723.1 module. As far as I can tell, it can be attributed to bitrot in formats/format_g723.c and Arkadi managed to produce a patch which rectifies the issue:

http://groups.google.com/group/asterisk-g729/browse_thread/thread/8471497e7dcbff26

NOTE: I neither use asterisk-1.6 nor G.723 but thought that this patch may be worthy of inclusion. I suppose it should be referred upstream.
Comment 1 kfm 2010-06-04 12:33:48 UTC
Created attachment 234111 [details, diff]
Arkadi's format_g723.c patch
Comment 2 Jaco Kroon 2010-06-07 09:02:24 UTC
You're right, upstream may be a problem.  Can anybody else confirm the patch works?  You will need to get the author of the patch to submit it upstream, including signing the online license thingy.

The patch doesn't apply to trunk cleanly, the first hunk fails but can be applied manually quite easily.  Thanks for notifying me Kerin.

Tony - patch carries my approval in principle, permitting we can get someone to test and confirm that it does in fact work.
Comment 3 Jaco Kroon 2010-06-07 09:04:59 UTC
Patch doesn't apply due to whitespace problems.  Fixing whitespace gets it to apply cleanly.
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2010-06-07 09:41:02 UTC
Please submit upstream and change the URL field to the upstream bug report. They will take ages to look at it; but I want to be submitted before I'll carry it.
Comment 5 Jaco Kroon 2010-09-16 10:30:44 UTC
Kerin?  Has this been reported upstream yet?  I don't care too much about this personally but I suspect this is another easy one to get off the growing (my fault to a large extent) list of reports against voip (asterisk) on Gentoo.
Comment 6 kfm 2010-09-16 10:38:31 UTC
I don't believe so. Should that presumption hold true, I'll try to remember to report it this evening.
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2011-09-01 14:39:52 UTC
The 1.6.2 branch of Asterisk is no longer in portage. I have not heard of this being reported upstream, as such I am closing this report.