Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 321753 - net-proxy/tinyproxy-1.8.1 - add "-doc" use
Summary: net-proxy/tinyproxy-1.8.1 - add "-doc" use
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Network Proxy Developers (OBSOLETE)
URL: http://sources.gentoo.org/cgi-bin/vie...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-28 03:38 UTC by jakie jia
Modified: 2010-06-04 05:28 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to remove docs (tinyproxy-1.8.1-nodocs.patch,3.25 KB, patch)
2010-06-03 19:30 UTC, Ben Kohler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jakie jia 2010-05-28 03:38:42 UTC
tinyproxy-1.8.1 itself is 199kb, but is pulling asiidoc with other dependencies of more than 20mb.

patch is available at https://dev.openwrt.org/browser/packages/net/tinyproxy/patches/010-no-docs-and-tests.patch

Reproducible: Always
Comment 1 Ben Kohler gentoo-dev 2010-06-03 19:28:50 UTC
I think a doc flag is a wonderful idea, forcing 17 (SEVENTEEN!) new packages just to build some docs seems excessive.  And that's 17 on my USE="-* ssl unicode" setup, could be worse for others.  There were several problems with OpenWRT's patch for me, so I used it as a guide to whip up my own.
Comment 2 Ben Kohler gentoo-dev 2010-06-03 19:30:58 UTC
Created attachment 234027 [details, diff]
patch to remove docs
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2010-06-03 20:58:01 UTC
I've updated the 1.8.1 in a fashion similar to the attached patch (right before it was posted, sorry), but I stopped short of patching all the Makefile.am's and configure.ac out there and just made sure configure finds something that looks like a2x by linking /bin/true to ${T}/a2x and then adding ${T} to PATH in the ebuild. 8-)

That way I keep the patching at a minimum and leave configure to its erroneous way of producing an error instead of simply not building the documentation.

USE=minimal is what you should look for instead of USE=doc.

With USE=-minimal you now get:
usr/sbin/tinyproxy
usr/share/tinyproxy/debug.html
usr/share/tinyproxy/default.html
usr/share/tinyproxy/stats.html
usr/share/man/man5/tinyproxy.conf.5.bz2
usr/share/man/man8/tinyproxy.8.bz2
usr/share/doc/tinyproxy-1.8.1/NEWS.bz2
usr/share/doc/tinyproxy-1.8.1/README.bz2
usr/share/doc/tinyproxy-1.8.1/TODO.bz2
usr/share/doc/tinyproxy-1.8.1/AUTHORS.bz2
usr/share/doc/tinyproxy-1.8.1/ChangeLog.bz2
usr/lib/debug/usr/sbin/tinyproxy.debug
etc/tinyproxy.conf
etc/init.d/tinyproxy

whereas with USE=minimal, you get:
usr/sbin/tinyproxy
usr/share/tinyproxy/debug.html
usr/share/tinyproxy/default.html
usr/share/tinyproxy/stats.html
usr/lib/debug/usr/sbin/tinyproxy.debug
etc/tinyproxy.conf
etc/init.d/tinyproxy

and of course asciidoc isn't installed.

I've also fixed what I think was an error, in moving the three HTML templates from their paths as described in tinyproxy.conf to the normal docdir Gentoo uses. That change was introduced in the [URL] (when tinyproxy was at home in net-www and before it was at home in www-proxy).
Comment 4 Ben Kohler gentoo-dev 2010-06-04 00:04:47 UTC
Shouldn't it be DEPEND="!minimal? ( app-text/asciidoc )" ?
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2010-06-04 05:28:50 UTC
Of course! Thanks for noticing. This is what you get when you change the USE flag half way through rewriting the ebuild. :)

Fixed again.